Issue 7452 - Do not cache element hiding filter objects by default

test/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 const {createSandbox} = require("./_common");
 
 let ElemHide = null;
 let createStyleSheet = null;
 let rulesFromStyleSheet = null;
 let ElemHideExceptions = null;
 let Filter = null;
-let filtersByDomain = null;
+let filterTextByDomain = null;
 let selectorGroupSize = null;
 
 exports.setUp = function(callback)
 {
   let sandboxedRequire = createSandbox({
     extraExports: {
-      elemHide: ["filtersByDomain", "selectorGroupSize"]
+      elemHide: ["filterTextByDomain", "selectorGroupSize"]
     }
   });
   (
     {ElemHide, createStyleSheet, rulesFromStyleSheet,
-     filtersByDomain, selectorGroupSize} = sandboxedRequire("../lib/elemHide"),
+     filterTextByDomain, selectorGroupSize} = sandboxedRequire("../lib/elemHide"),
     {ElemHideExceptions} = sandboxedRequire("../lib/elemHideExceptions"),
     {Filter} = sandboxedRequire("../lib/filterClasses")
   );
 
   callback();
 };
 
 function normalizeSelectors(selectors)
 {
   // generateStyleSheetForDomain is currently allowed to return duplicate
@@ skipping 223 matching lines @@
 {
   ElemHide.add(Filter.fromText("##test"));
   ElemHideExceptions.add(Filter.fromText("foo.com#@#test"));
   testResult(test, "foo.com", [], {expectedExceptions: ["foo.com#@#test"]});
   testResult(test, "bar.com", ["test"]);
   test.done();
 };
 
 exports.testFiltersByDomain = function(test)
 {
-  test.equal(filtersByDomain.size, 0);
+  test.equal(filterTextByDomain.size, 0);
 
   ElemHide.add(Filter.fromText("##test"));
-  test.equal(filtersByDomain.size, 0);
+  test.equal(filterTextByDomain.size, 0);
 
   ElemHide.add(Filter.fromText("example.com##test"));
-  test.equal(filtersByDomain.size, 1);
+  test.equal(filterTextByDomain.size, 1);
 
   ElemHide.add(Filter.fromText("example.com,~www.example.com##test"));
-  test.equal(filtersByDomain.size, 2);
+  test.equal(filterTextByDomain.size, 2);
 
   ElemHide.remove(Filter.fromText("example.com##test"));
-  test.equal(filtersByDomain.size, 2);
+  test.equal(filterTextByDomain.size, 2);
 
   ElemHide.remove(Filter.fromText("example.com,~www.example.com##test"));
-  test.equal(filtersByDomain.size, 0);
+  test.equal(filterTextByDomain.size, 0);
 
   test.done();
 };
 
 exports.testCreateStyleSheet = function(test)
 {
   test.equal(
     createStyleSheet([
       "html", "#foo", ".bar", "#foo .bar", "#foo > .bar",
       "#foo[data-bar='bar']"
@@ skipping 30 matching lines @@
   // not the case, the function goes into an infinite loop. It should only be
   // used with the return value of the createStyleSheet function.
 
   test.deepEqual([...rulesFromStyleSheet("")], []);
   test.deepEqual([...rulesFromStyleSheet("#foo {}\n")], ["#foo {}"]);
   test.deepEqual([...rulesFromStyleSheet("#foo {}\n#bar {}\n")],
                  ["#foo {}", "#bar {}"]);
 
   test.done();
 };