Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29940622: Issue 7116 Run browser test in Microsoft Edge (Closed)

Created:
Nov. 8, 2018, 10:01 p.m. by geo
Modified:
Nov. 10, 2018, 2:02 a.m.
Reviewers:
Sebastian Noack, tlucas
Visibility:
Public.

Description

Issue 7116 Run browser test in Microsoft Edge This patch is on top of https://codereview.adblockplus.org/29891680/

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
A test/runners/edge_process.js View 1 1 chunk +42 lines, -0 lines 0 comments Download
M test_runner.js View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
geo
https://codereview.adblockplus.org/29940622/diff/29940623/test/runners/edge_process.js File test/runners/edge_process.js (right): https://codereview.adblockplus.org/29940622/diff/29940623/test/runners/edge_process.js#newcode1 test/runners/edge_process.js:1: /* This is a new file.
Nov. 8, 2018, 10:13 p.m. (2018-11-08 22:13:34 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29940622/diff/29940623/test/runners/edge_process.js File test/runners/edge_process.js (left): https://codereview.adblockplus.org/29940622/diff/29940623/test/runners/edge_process.js#oldcode24 test/runners/edge_process.js:24: Nit: The blank line here seems superfluous. https://codereview.adblockplus.org/29940622/diff/29940623/test/runners/edge_process.js File ...
Nov. 9, 2018, 7:13 p.m. (2018-11-09 19:13:44 UTC) #2
geo
https://codereview.adblockplus.org/29940622/diff/29940623/test/runners/edge_process.js File test/runners/edge_process.js (left): https://codereview.adblockplus.org/29940622/diff/29940623/test/runners/edge_process.js#oldcode24 test/runners/edge_process.js:24: On 2018/11/09 19:13:43, Sebastian Noack wrote: > Nit: The ...
Nov. 9, 2018, 7:45 p.m. (2018-11-09 19:45:10 UTC) #3
Sebastian Noack
Nov. 9, 2018, 8:39 p.m. (2018-11-09 20:39:42 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld