Issue 7114 - Remove az and untranslated resources from Windows packages

Issue 7114 - Remove az and untranslated resources from Windows packages

[Sebastian Noack, 2018-11-20 01:55:46]

Geo, can you try the following?

1. Apply the patch to adblockpluschrome/buildtools
2. Run "build.py build -t edge"
3. Self-sign the resulting build
4. Try to install it locally

[Sebastian Noack, 2018-11-20 03:07:42]

On 2018/11/20 01:55:46, Sebastian Noack wrote:
> 2. Run "build.py build -t edge"

For got to mention, you have to set SKIP_DEPENDENCY_UPDATES=1 if you have local
modifications in the buildtools subfolder.

[geo, 2018-11-20 19:50:41]

On 2018/11/20 03:07:42, Sebastian Noack wrote:
> On 2018/11/20 01:55:46, Sebastian Noack wrote:
> > 2. Run "build.py build -t edge"
> 
> For got to mention, you have to set SKIP_DEPENDENCY_UPDATES=1 if you have
local
> modifications in the buildtools subfolder.

I've tested the patch, however it won't install. The problem is that there is a
discrepancy between the languages from `appxmanifest.xml` and what we have in
the `Resources` directory. Is it possible to add the languages to
`appxmanifest.xml` after we create the `Resources` and only if a language is
there? An other option (if available) could be to use `MakePRI` as described
here:
https://docs.microsoft.com/en-us/microsoft-edge/extensions/guides/packaging/l...

[Sebastian Noack, 2018-11-20 21:35:53]

As per the discussion on IRC, it seems that the package doesn't install either
if it has any localized resources for the 'az' locale (renaming it to az-latn
works but then the translation isn't picked up either, so we can as well just
remove it), or if the manifest lists the 'uz' locale without providing a
translation for the description.

In order to keep things simple and as consistent as possible, I uploaded a new
patch that removes the "Resources/az" folder, and then removes every <Resource>
element from appxmanifest.xml that doesn't have a corresponding subfolder under
"Resources".

Can you test again with the new patch? Thanks.

[geo, 2018-11-21 18:29:02]

On 2018/11/20 21:35:53, Sebastian Noack wrote:
> As per the discussion on IRC, it seems that the package doesn't install either
> if it has any localized resources for the 'az' locale (renaming it to az-latn
> works but then the translation isn't picked up either, so we can as well just
> remove it), or if the manifest lists the 'uz' locale without providing a
> translation for the description.
> 
> In order to keep things simple and as consistent as possible, I uploaded a new
> patch that removes the "Resources/az" folder, and then removes every
<Resource>
> element from appxmanifest.xml that doesn't have a corresponding subfolder
under
> "Resources".
> 
> Can you test again with the new patch? Thanks.

LGTM.