Unified Diff: lib/notificationHelper.js
Issue 29948561:
Issue 7093 - Only animate icon for global notifications (Closed)
Patch Set:
Created Nov. 20, 2018, 5:48 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/notificationHelper.js |
| =================================================================== |
| --- a/lib/notificationHelper.js |
| +++ b/lib/notificationHelper.js |
| @@ -40,7 +40,8 @@ |
| function prepareNotificationIconAndPopup() |
| { |
| - let animateIcon = shouldDisplay("icon", activeNotification.type); |
| + let animateIcon = !(activeNotification.urlFilters instanceof Array) && |
|
kzar
2018/11/20 20:20:42
Nit: I figure we could just check that `urlFilters
Thomas Greiner
2018/11/21 11:55:58
You're probably right. Given that this data is com
|
| + shouldDisplay("icon", activeNotification.type); |
| activeNotification.onClicked = () => |
| { |
| if (animateIcon) |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
