Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29954557: Noissue - Update selenium-webdriver to 4.0.0-alpha (Closed)

Created:
Nov. 29, 2018, 3:12 p.m. by hub
Modified:
Dec. 12, 2018, 12:49 p.m.
Reviewers:
Manish Jethani, kzar, tlucas
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Update selenium-webdriver to 4.0.0-alpha We want to do that do match the version used in the WebExtension.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M package.json View 1 chunk +1 line, -1 line 0 comments Download
M test/runners/firefox_process.js View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3
hub
Nov. 29, 2018, 3:12 p.m. (2018-11-29 15:12:37 UTC) #1
Manish Jethani
Fine with me, though not really my area so I'll move myself to CC and ...
Nov. 30, 2018, 8:32 a.m. (2018-11-30 08:32:04 UTC) #2
kzar
Nov. 30, 2018, 12:41 p.m. (2018-11-30 12:41:53 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld