Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1021)

Issue 29969555: Issue 7039 - [XTM Integration] Make parameter naming consistent with the API docs

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 3 weeks ago by Tudor Avram
Modified:
10 months ago
Reviewers:
Vasily Kuznetsov
CC:
wspee
Visibility:
Public.

Description

Issue 7039 - [XTM Integration] Make parameter naming consistent with the API docs

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M cms/translations/xtm/cli.py View 2 chunks +4 lines, -4 lines 2 comments Download
M cms/translations/xtm/constants.py View 1 chunk +1 line, -1 line 0 comments Download
M cms/translations/xtm/projects_handler.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_xtm_translate.py View 6 chunks +8 lines, -8 lines 0 comments Download
M tests/utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Tudor Avram
Hi Vasily and Winsley, I updated the name for a couple of parameters to match ...
10 months, 3 weeks ago (2018-12-28 14:52:43 UTC) #1
Vasily Kuznetsov
Hi Tudor, All looks good except for the Username -> Client name. See comment below. ...
10 months, 2 weeks ago (2019-01-04 20:21:14 UTC) #2
Tudor Avram
Hi Vasily, Thanks for the review! That change was made at Winsley's suggestion (see below ...
10 months, 1 week ago (2019-01-11 13:03:42 UTC) #3
Vasily Kuznetsov
10 months ago (2019-01-14 14:05:24 UTC) #4
On 2019/01/11 13:03:42, Tudor Avram wrote:
> Hi Vasily, 
> 
> Thanks for the review! That change was made at Winsley's suggestion (see below
> for more details.
> 
> Tudor.
> 
>
https://codereview.adblockplus.org/29969555/diff/29969556/cms/translations/xt...
> File cms/translations/xtm/cli.py (right):
> 
>
https://codereview.adblockplus.org/29969555/diff/29969556/cms/translations/xt...
> cms/translations/xtm/cli.py:46: username = input_fn('Client name: ')
> On 2019/01/04 20:21:14, Vasily Kuznetsov wrote:
> > Do you think it will be more clear to say "Client name" instead of
"Username"
> > when we're talking about logging into the API and stuff like that? Not sure
if
> > people would know the terminology but I would probably be more confused this
> > way.
> 
> That was why I used `username` initially, but Winsley said in the original
issue
> that he finds it confusing and he'd rather have `client name` in there: see
>
https://codereview.adblockplus.org/29886648/diff/29902698/cms/translations/xt...
> so I changed it at his suggestion. Also, this is consistent with their web
> login, so I guess it makes sense to leave it as `client name`.

Ok then, LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5