Issue 7039 - [XTM Integration] Make parameter naming consistent with the API docs

Issue 7039 - [XTM Integration] Make parameter naming consistent with the API docs

[Tudor Avram, 2018-12-28 14:52:43]

Hi Vasily and Winsley,

I updated the name for a couple of parameters to match the XTM API
documentation.

Let me know what you think.

Tudor.

[Vasily Kuznetsov, 2019-01-04 20:21:14]

Hi Tudor,

All looks good except for the Username -> Client name. See comment below.

Cheers,
Vasily

https://codereview.adblockplus.org/29969555/diff/29969556/cms/translations/xt...
File cms/translations/xtm/cli.py (right):

https://codereview.adblockplus.org/29969555/diff/29969556/cms/translations/xt...
cms/translations/xtm/cli.py:46: username = input_fn('Client name: ')
Do you think it will be more clear to say "Client name" instead of "Username"
when we're talking about logging into the API and stuff like that? Not sure if
people would know the terminology but I would probably be more confused this
way.

[Tudor Avram, 2019-01-11 13:03:42]

Hi Vasily, 

Thanks for the review! That change was made at Winsley's suggestion (see below
for more details.

Tudor.

https://codereview.adblockplus.org/29969555/diff/29969556/cms/translations/xt...
File cms/translations/xtm/cli.py (right):

https://codereview.adblockplus.org/29969555/diff/29969556/cms/translations/xt...
cms/translations/xtm/cli.py:46: username = input_fn('Client name: ')
On 2019/01/04 20:21:14, Vasily Kuznetsov wrote:
> Do you think it will be more clear to say "Client name" instead of "Username"
> when we're talking about logging into the API and stuff like that? Not sure if
> people would know the terminology but I would probably be more confused this
> way.

That was why I used `username` initially, but Winsley said in the original issue
that he finds it confusing and he'd rather have `client name` in there: see
https://codereview.adblockplus.org/29886648/diff/29902698/cms/translations/xt...
so I changed it at his suggestion. Also, this is consistent with their web
login, so I guess it makes sense to leave it as `client name`.

[Vasily Kuznetsov, 2019-01-14 14:05:24]

On 2019/01/11 13:03:42, Tudor Avram wrote:
> Hi Vasily, 
> 
> Thanks for the review! That change was made at Winsley's suggestion (see below
> for more details.
> 
> Tudor.
> 
>
https://codereview.adblockplus.org/29969555/diff/29969556/cms/translations/xt...
> File cms/translations/xtm/cli.py (right):
> 
>
https://codereview.adblockplus.org/29969555/diff/29969556/cms/translations/xt...
> cms/translations/xtm/cli.py:46: username = input_fn('Client name: ')
> On 2019/01/04 20:21:14, Vasily Kuznetsov wrote:
> > Do you think it will be more clear to say "Client name" instead of
"Username"
> > when we're talking about logging into the API and stuff like that? Not sure
if
> > people would know the terminology but I would probably be more confused this
> > way.
> 
> That was why I used `username` initially, but Winsley said in the original
issue
> that he finds it confusing and he'd rather have `client name` in there: see
>
https://codereview.adblockplus.org/29886648/diff/29902698/cms/translations/xt...
> so I changed it at his suggestion. Also, this is consistent with their web
> login, so I guess it makes sense to leave it as `client name`.

Ok then, LGTM