Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(366)

Issue 29973555: Issue 7192 - Remove unused qunit/common.js file from webpack bundle (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by kzar
Modified:
1 year, 2 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 7192 - Remove unused qunit/common.js file from webpack bundle

Patch Set 1 #

Patch Set 2 : Remove common.js from tox tests too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M packagerChrome.py View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/test_packagerWebExt.py View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7
kzar
Patch Set 1 Moving this over to Rietveld since there's some issues with the GitLab ...
1 year, 3 months ago (2019-01-04 15:22:58 UTC) #1
Sebastian Noack
LGTM
1 year, 2 months ago (2019-01-04 21:17:54 UTC) #2
Sebastian Noack
Sorry, I might have been a little to quick. Can you adapt tests/test_packagerWebEXt.py to no ...
1 year, 2 months ago (2019-01-04 22:08:28 UTC) #3
kzar
Patch Set 2 : Remove common.js from tox tests too On 2019/01/04 22:08:28, Sebastian Noack ...
1 year, 2 months ago (2019-01-05 13:00:07 UTC) #4
Sebastian Noack
On 2019/01/05 13:00:07, kzar wrote: > Whoops, good point. Done. I'm still getting that error ...
1 year, 2 months ago (2019-01-05 22:05:33 UTC) #5
kzar
On 2019/01/05 22:05:33, Sebastian Noack wrote: > On 2019/01/05 13:00:07, kzar wrote: > > Whoops, ...
1 year, 2 months ago (2019-01-07 10:24:50 UTC) #6
kzar
1 year, 2 months ago (2019-01-07 14:28:02 UTC) #7
Message was sent while issue was closed.
On 2019/01/05 22:05:33, Sebastian Noack wrote:
> (or if you want fix those with a separate change).

I looked into this a bit more, and filed #7194 and #7196.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5