Issue 7192 - Remove unused qunit/common.js file from webpack bundle

Issue 7192 - Remove unused qunit/common.js file from webpack bundle

[kzar, 2019-01-04 15:22:58]

Patch Set 1

Moving this over to Rietveld since there's some issues with the GitLab mirror.
Take a look at my note about tox[1] in the old GitLab review.

[1] 
-
https://gitlab.com/eyeo/adblockplus/abpui/buildtools/merge_requests/1#note_12...

[Sebastian Noack, 2019-01-04 21:17:54]

LGTM

[Sebastian Noack, 2019-01-04 22:08:28]

Sorry, I might have been a little to quick. Can you adapt
tests/test_packagerWebEXt.py to no longer add qunit/common.js to the test
builds?

[kzar, 2019-01-05 13:00:07]

Patch Set 2 : Remove common.js from tox tests too

On 2019/01/04 22:08:28, Sebastian Noack wrote:
> Can you adapt tests/test_packagerWebEXt.py to no
> longer add qunit/common.js to the test builds?

Whoops, good point. Done. I'm still getting that error message when running
tox[1], but the tests all seem to be passing.

FWIW I also compared the chrome, gecko and edge builds when built before and
after this change. Only devenvVersion__, qunit/tests.js and qunit/tests.js.map
changed, like I expected.

[1] -
https://gitlab.com/eyeo/adblockplus/abpui/buildtools/merge_requests/1#note_12...

[Sebastian Noack, 2019-01-05 22:05:33]

On 2019/01/05 13:00:07, kzar wrote:
> Whoops, good point. Done. I'm still getting that error message when running
> tox[1], but the tests all seem to be passing.
> 
> ...
> 
> [1] -
>
https://gitlab.com/eyeo/adblockplus/abpui/buildtools/merge_requests/1#note_12...

I don't seem to have permissions to access that. But assuming you are talking
about the W504 reported by flake8, at some point new versions of flake8 started
to detect that issue, and therefore without changes to our code flake8 is
failing now. You can ignore that (or if you want fix those with a separate
change).

LGTM, if this is the only error reported through tox.

[kzar, 2019-01-07 10:24:50]

On 2019/01/05 22:05:33, Sebastian Noack wrote:
> On 2019/01/05 13:00:07, kzar wrote:
> > Whoops, good point. Done. I'm still getting that error message when running
> > tox[1], but the tests all seem to be passing.
> > 
> > ...
> > 
> > [1] -
> >
>
https://gitlab.com/eyeo/adblockplus/abpui/buildtools/merge_requests/1#note_12...
> 
> I don't seem to have permissions to access that.

Oh dang, sorry I didn't realise.

> ... and therefore without changes to our code flake8 is
> failing now. You can ignore that (or if you want fix those
> with a separate change).

I just double checked, after my change I get one less flake8 error than before.
So I'll
go ahead and push this.

[kzar, 2019-01-07 14:28:02]

On 2019/01/05 22:05:33, Sebastian Noack wrote:
> (or if you want fix those with a separate change).

I looked into this a bit more, and filed #7194 and #7196.