Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: packagerChrome.py

Issue 29973555: Issue 7192 - Remove unused qunit/common.js file from webpack bundle (Closed)
Patch Set: Remove common.js from tox tests too Created Jan. 5, 2019, 12:55 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/test_packagerWebExt.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: packagerChrome.py
diff --git a/packagerChrome.py b/packagerChrome.py
index e92ca3e2c3a3b39318313243c418e8a6c71f93ca..42fff4d8d908559a8bb08a0591a7fbdfa6a1a1dd 100644
--- a/packagerChrome.py
+++ b/packagerChrome.py
@@ -207,12 +207,10 @@ def create_bundles(params, files, bundle_tests):
})
if bundle_tests:
- qunit_path = os.path.join(base_extension_path, 'qunit')
- qunit_files = ([os.path.join(qunit_path, 'common.js')] +
- glob.glob(os.path.join(qunit_path, 'tests', '*.js')))
+ test_paths = os.path.join(base_extension_path, 'qunit', 'tests', '*.js')
configuration['bundles'].append({
'bundle_name': 'qunit/tests.js',
- 'entry_points': qunit_files,
+ 'entry_points': glob.glob(test_paths),
})
cmd = ['node', os.path.join(os.path.dirname(__file__), 'webpack_runner.js')]
« no previous file with comments | « no previous file | tests/test_packagerWebExt.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld