Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29977568: Issue 7198 - Hide ABP extension from dropdown menu (Closed)

Created:
Jan. 9, 2019, 9:08 p.m. by diegocarloslima
Modified:
Jan. 21, 2019, 12:04 p.m.
Reviewers:
anton, jens
Visibility:
Public.

Description

Issue 7198 - Hide ABP extension from dropdown menu

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M mobile/android/base/java/org/mozilla/gecko/BrowserApp.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3
diegocarloslima
Jan. 9, 2019, 9:09 p.m. (2019-01-09 21:09:00 UTC) #1
jens
On 2019/01/09 21:09:00, diegocarloslima wrote: LGTM
Jan. 10, 2019, 2:20 p.m. (2019-01-10 14:20:10 UTC) #2
anton
Jan. 16, 2019, 4:53 p.m. (2019-01-16 16:53:23 UTC) #3
On 2019/01/09 21:09:00, diegocarloslima wrote:

LGTM though a bit confused with one-liner `if (..) return` (missing {} and
return in the next line.

Powered by Google App Engine
This is Rietveld