Issue 29979555: Issue 7207 - Implement abort-on-property-write snippet

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29979555: Issue 7207 - Implement abort-on-property-write snippet (Closed)

Created:
Jan. 11, 2019, 2:39 p.m. by hub

Modified:
Jan. 15, 2019, 5:34 p.m.

Reviewers:
Manish Jethani

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Issue 7207 - Implement abort-on-property-write snippet

Patch Set 2 : Addressed comment typo #

Created: Jan. 15, 2019, 4:40 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1 line)			Patch
	M	lib/content/snippets.js	View	1	2 chunks	+33 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Manish Jethani

https://codereview.adblockplus.org/29979555/diff/29979556/lib/content/snippets.js File lib/content/snippets.js (right): https://codereview.adblockplus.org/29979555/diff/29979556/lib/content/snippets.js#newcode763 lib/content/snippets.js:763: * property is written (set). Nit: I don't think ...

Jan. 15, 2019, 2:13 p.m. (2019-01-15 14:13:30 UTC) #2

hub

updated patch https://codereview.adblockplus.org/29979555/diff/29979556/lib/content/snippets.js File lib/content/snippets.js (right): https://codereview.adblockplus.org/29979555/diff/29979556/lib/content/snippets.js#newcode763 lib/content/snippets.js:763: * property is written (set). On 2019/01/15 ...

Jan. 15, 2019, 4:40 p.m. (2019-01-15 16:40:30 UTC) #4

Manish Jethani

Jan. 15, 2019, 5:24 p.m. (2019-01-15 17:24:16 UTC) #5

LGTM

https://codereview.adblockplus.org/29979555/diff/29979556/lib/content/snippet...
File lib/content/snippets.js (right):

https://codereview.adblockplus.org/29979555/diff/29979556/lib/content/snippet...
lib/content/snippets.js:784: if (wrapPropertyAccess(window, property, {set:
abort}))
On 2019/01/15 16:40:30, hub wrote:
> On 2019/01/15 14:13:29, Manish Jethani wrote:
> > Do we need a getter here?
> 
> We don't.

Acknowledged.

Expand All Messages | Collapse All Messages