Noissue - Fixed: extension_id_* option was ignored in builds for MS Edge

packagerEdge.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import os
 import shutil
 import json
 import re
 from StringIO import StringIO
 from glob import glob
 import subprocess
 import tempfile
 from xml.etree import ElementTree
 from zipfile import ZipFile
+import ConfigParser
 
 import packager
 import packagerChrome
 
 MANIFEST = 'appxmanifest.xml'
 ASSETS_DIR = 'Assets'
 
 defaultLocale = packagerChrome.defaultLocale
 
 
@@ skipping 38 matching lines @@
     filenames = []
 
     for name, path in metadata.items('appx_assets'):
         path = os.path.join(base_dir, path)
         icon_path = '{}/{}'.format(ASSETS_DIR, name)
 
         files.read(path, icon_path)
         filenames.append(icon_path)
 
     assets = packagerChrome.makeIcons(files, filenames)
-
     author = metadata.get('general', 'author')
 
     overrides = [
         ('_d:Identity', None, [
             ('Name', packager.get_app_id(release_build, metadata)),
             ('Publisher', metadata.get('general', 'publisher_id')),
             ('Version', get_appx_version(metadata, build_num)),
         ]),
         ('_d:Properties/_d:PublisherDisplayName', author, []),
         ('_d:Properties/_d:Logo', assets[50], []),
         ('_d:Dependencies/_d:TargetDeviceFamily', None, [
             ('MaxVersionTested', v_max),
             ('MinVersion', v_min),
         ]),
         ('_d:Applications/_d:Application/uap:VisualElements', None, [
             ('Square150x150Logo', assets[150]),
             ('Square44x44Logo', assets[44]),
         ]),
     ]
 
+    try:
+        overrides.append((
+            '_d:Applications/_d:Application/_d:Extensions/' +
+            'uap3:Extension/uap3:AppExtension',
+            None,
+            [('Id', packager.get_build_specific_option(release_build,
+                                                       metadata,
+                                                       'extension_id'))],
+        ))
+    except ConfigParser.NoOptionError:
+        pass
+
     tree = ElementTree.parse(manifest_path)
     root = tree.getroot()
 
     for xpath, text, attributes in overrides:
         element = root.find(xpath, namespaces)
         if text:
             element.text = text
         for attr, value in attributes:
                 element.set(attr, value)
 
@@ skipping 115 matching lines @@
         cmd = ['npm', 'run', '--silent', 'package-edge']
 
         subprocess.check_call(cmd, env=cmd_env, cwd=os.path.dirname(__file__))
 
         package = os.path.join(manifold_folder, 'package',
                                'edgeExtension.appx')
 
         shutil.copyfile(package, outfile)
     finally:
         shutil.rmtree(tmp_dir, ignore_errors=True)