Issue 29983597: Noissue - Fixed: extension_id_* option was ignored in builds for MS Edge

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29983597: Noissue - Fixed: extension_id_* option was ignored in builds for MS Edge (Closed)

Created:
Jan. 17, 2019, 1:19 a.m. by Sebastian Noack

Modified:
Jan. 17, 2019, 2:15 a.m.

Reviewers:
tlucas

Visibility:
Public.

Description

Noissue - Fixed: extension_id_* option was ignored in builds for MS Edge

Patch Set 1 #

Created: Jan. 17, 2019, 1:19 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -6 lines)			Patch
M	packager.py	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	packagerEdge.py	View	3 chunks	+13 lines, -1 line	0 comments	Download
M	tests/expecteddata/AppxManifest_edge_release_build.xml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sebastian Noack

This change already landed, and was used to create the release build of Adblock Plus ...

Jan. 17, 2019, 1:22 a.m. (2019-01-17 01:22:08 UTC) #1

tlucas

Jan. 17, 2019, 1:34 a.m. (2019-01-17 01:34:07 UTC) #2

On 2019/01/17 01:22:08, Sebastian Noack wrote:
> This change already landed, and was used to create the release build of
Adblock
> Plus 0.9.12 for Microsoft Edge.
> 
> Sorry for landing this change, before passing review. However, this was the
only
> way to move forward with the release.

It's ok, FWIW -> LGTM

Expand All Messages | Collapse All Messages