Issue 6959 - Use async/await in test/browser/elemHideEmulation.js

[Manish Jethani, 2019-01-17 08:03:34]

Patch Set 1

Initial patch to show the basic idea.

Patch Sets 2-7

Incremental changes leading up to the final patch.

https://codereview.adblockplus.org/29984555/diff/29984556/test/browser/elemHi...
File test/browser/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29984555/diff/29984556/test/browser/elemHi...
test/browser/elemHideEmulation.js:153: await Promise.resolve();
This should not be necessary but I left it in for compatibility with the
previous version. We should be able to just create the ElemHideEmulation object
and apply the selectors synchronously.

https://codereview.adblockplus.org/29984555/diff/29984556/test/browser/elemHi...
test/browser/elemHideEmulation.js:175: if (!test)
This should not be necessary if every call to this function passes in the test
object.

https://codereview.adblockplus.org/29984555/diff/29984558/test/browser/elemHi...
File test/browser/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29984555/diff/29984558/test/browser/elemHi...
test/browser/elemHideEmulation.js:588:
exports.testPseudoClassHasSelectorWithSuffixSiblingNoop = async function(test)
Some functions don't really need to be async but it doesn't hurt either.

https://codereview.adblockplus.org/29984555/diff/29984558/test/browser/elemHi...
test/browser/elemHideEmulation.js:783: await timeout(0);
Now we can just wait on the timeout.

[Manish Jethani, 2019-01-17 08:04:37]

https://codereview.adblockplus.org/29984555/diff/29984556/test/browser/elemHi...
File test/browser/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29984555/diff/29984556/test/browser/elemHi...
test/browser/elemHideEmulation.js:175: if (!test)
On 2019/01/17 08:03:33, Manish Jethani wrote:
> This should not be necessary if every call to this function passes in the test
> object.

Removed now.

https://codereview.adblockplus.org/29984555/diff/29984558/test/browser/elemHi...
File test/browser/elemHideEmulation.js (right):

https://codereview.adblockplus.org/29984555/diff/29984558/test/browser/elemHi...
test/browser/elemHideEmulation.js:588:
exports.testPseudoClassHasSelectorWithSuffixSiblingNoop = async function(test)
On 2019/01/17 08:03:33, Manish Jethani wrote:
> Some functions don't really need to be async but it doesn't hurt either.

Removed now.

[Manish Jethani, 2019-01-17 08:07:09]

FWIW it takes a while to wrap one's head around async/await. I found this
article to be helpful: https://javascript.info/async-await

[hub, 2019-01-17 18:24:34]

LGTM