Robert brought it to my attention that the filters for the circumvention test
pages disappeared from the subscription when we started to automatically
generate the filter list. That is because they were never listed on the test
case page itself in the first place. While on it, I also made the necessary to
those test pages to pass the test automation.
LGTM, I wonder if the automation should verify all the tests fail when the filter ...
On 2019/01/17 09:46:06, kzar wrote:
> LGTM, I wonder if the automation should verify all the tests fail when the
> filter isn't added as well?
It was intentional that the automation ignores test pages that don't list any
filters, assuming some tests cannot be automated. However, we could reconsider
BTW, if these changes would land right now, it would break our automation. I
submitted another review for the required adaptions there:
Issue 29984560: Noissue - Make circumvention test automatable and add missing filters
Created Jan. 17, 2019, 7:30 a.m. by Sebastian Noack
Modified Jan. 17, 2019, 10:44 p.m.
Reviewers: rossg, kzar