Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29984560: Noissue - Make circumvention test automatable and add missing filters (Closed)

Created:
Jan. 17, 2019, 7:30 a.m. by Sebastian Noack
Modified:
Jan. 17, 2019, 10:44 p.m.
Reviewers:
kzar, rossg
CC:
Robert Raceanu
Visibility:
Public.

Description

Noissue - Make circumvention test automatable and add missing filters

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M pages/circumvention/anoniframe-documentwrite.tmpl View 2 chunks +18 lines, -2 lines 0 comments Download
M pages/circumvention/inline-style-important.tmpl View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Sebastian Noack
Robert brought it to my attention that the filters for the circumvention test pages disappeared ...
Jan. 17, 2019, 7:33 a.m. (2019-01-17 07:33:50 UTC) #1
kzar
LGTM, I wonder if the automation should verify all the tests fail when the filter ...
Jan. 17, 2019, 9:46 a.m. (2019-01-17 09:46:06 UTC) #2
Sebastian Noack
Jan. 17, 2019, 11:42 a.m. (2019-01-17 11:42:45 UTC) #3
On 2019/01/17 09:46:06, kzar wrote:
> LGTM, I wonder if the automation should verify all the tests fail when the
> filter isn't added as well?

It was intentional that the automation ignores test pages that don't list any
filters, assuming some tests cannot be automated. However, we could reconsider
that now.

BTW, if these changes would land right now, it would break our automation. I
submitted another review for the required adaptions there:
https://codereview.adblockplus.org/29984574/

Powered by Google App Engine
This is Rietveld