Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29986555: Issue 7200 - Adjust UI colors (Closed)

Created:
Jan. 21, 2019, 6:56 p.m. by diegocarloslima
Modified:
Jan. 28, 2019, 5:27 p.m.
Reviewers:
anton, jens
Visibility:
Public.

Description

Issue 7200 - Adjust UI colors

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -159 lines) Patch
R mobile/android/app/src/main/res/color/abb_menu_icon.xml View 1 chunk +0 lines, -26 lines 0 comments Download
M mobile/android/app/src/main/res/color/tab_item_title.xml View 1 chunk +3 lines, -4 lines 0 comments Download
M mobile/android/app/src/main/res/drawable/shaped_button.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M mobile/android/app/src/main/res/drawable/tab_item_close_button.xml View 1 chunk +0 lines, -1 line 0 comments Download
M mobile/android/app/src/main/res/layout/tabs_panel_default.xml View 1 chunk +1 line, -2 lines 0 comments Download
M mobile/android/app/src/main/res/layout/tabs_panel_view.xml View 1 chunk +1 line, -2 lines 0 comments Download
M mobile/android/app/src/main/res/values-v21/themes.xml View 1 chunk +3 lines, -4 lines 0 comments Download
R mobile/android/app/src/main/res/values/abb_colors.xml View 1 chunk +0 lines, -32 lines 0 comments Download
R mobile/android/app/src/main/res/values/abb_dimens.xml View 1 chunk +0 lines, -24 lines 0 comments Download
R mobile/android/app/src/main/res/values/abb_styles.xml View 1 chunk +0 lines, -27 lines 0 comments Download
M mobile/android/app/src/main/res/values/themes.xml View 1 chunk +1 line, -2 lines 0 comments Download
M mobile/android/app/src/photon/res/values/styles.xml View 3 chunks +3 lines, -6 lines 2 comments Download
M mobile/android/base/java/org/mozilla/gecko/tabs/TabStrip.java View 1 chunk +2 lines, -4 lines 0 comments Download
M mobile/android/base/java/org/mozilla/gecko/tabs/TabsPanel.java View 2 chunks +4 lines, -8 lines 0 comments Download
M mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbar.java View 1 chunk +2 lines, -3 lines 0 comments Download
M mobile/android/base/java/org/mozilla/gecko/toolbar/BrowserToolbarPhoneBase.java View 1 chunk +1 line, -2 lines 0 comments Download
M mobile/android/base/java/org/mozilla/gecko/toolbar/ShapedButton.java View 1 chunk +2 lines, -4 lines 0 comments Download
M mobile/android/base/java/org/mozilla/gecko/toolbar/ShapedButtonFrameLayout.java View 1 chunk +2 lines, -4 lines 0 comments Download
M mobile/android/modules/WebrtcUI.jsm View 1 chunk +1 line, -1 line 0 comments Download
M mobile/android/themes/core/config.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
diegocarloslima
Jan. 21, 2019, 8:41 p.m. (2019-01-21 20:41:56 UTC) #1
jens
On 2019/01/21 20:41:56, diegocarloslima wrote: I can build the project right now to check if ...
Jan. 22, 2019, 9:35 a.m. (2019-01-22 09:35:51 UTC) #2
anton
https://codereview.adblockplus.org/29986555/diff/29986556/mobile/android/app/src/photon/res/values/styles.xml File mobile/android/app/src/photon/res/values/styles.xml (right): https://codereview.adblockplus.org/29986555/diff/29986556/mobile/android/app/src/photon/res/values/styles.xml#newcode364 mobile/android/app/src/photon/res/values/styles.xml:364: <item name="android:textColor">#FFA62F</item> shouldn't it be in @color/.. ?
Jan. 28, 2019, 5:53 a.m. (2019-01-28 05:53:03 UTC) #3
anton
On 2019/01/21 20:41:56, diegocarloslima wrote: LGTM (one minor comment though)
Jan. 28, 2019, 5:53 a.m. (2019-01-28 05:53:28 UTC) #4
diegocarloslima
Jan. 28, 2019, 11:43 a.m. (2019-01-28 11:43:08 UTC) #5 
https://codereview.adblockplus.org/29986555/diff/29986556/mobile/android/app/...
File mobile/android/app/src/photon/res/values/styles.xml (right):

https://codereview.adblockplus.org/29986555/diff/29986556/mobile/android/app/...
mobile/android/app/src/photon/res/values/styles.xml:364: <item
name="android:textColor">#FFA62F</item>
On 2019/01/28 05:53:03, anton wrote:
> shouldn't it be in @color/.. ?

Yeap, but I basically reverted this to the upstream code. So this is how Mozilla
have defined it, and thats why we should keep like this

Powered by Google App Engine
This is Rietveld