Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: package.json

Issue 29987559: Noissue - Add "ajv" peer-dependency (Closed)
Patch Set: Created Jan. 22, 2019, 1:02 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: package.json
diff --git a/package.json b/package.json
index b3298c4f0400cbd1de36090a81fc41eeff497890..c38321112c7c782e3c6c6ff43e8fd1082b34f55e 100644
--- a/package.json
+++ b/package.json
@@ -4,9 +4,11 @@
"license": "MPL-2.0",
"dependencies": {
"//": [
- "'acorn' is a peer dependency of manifoldjs, we don't use it otherwise."
+ "'acorn' and 'ajv' are peer dependencies of manifoldjs, we don't use",
kzar 2019/01/22 16:04:47 Aren't these called "transitive dependencies"?
kzar 2019/01/22 16:04:47 Did you mean to append the comma? I figure you mig
tlucas 2019/01/22 16:08:00 I did, i wanted to stick to 80 characters. for th
kzar 2019/01/22 16:12:36 Ah, gotya. Good to know, thanks.
+ " them otherwise."
],
"acorn": "^6.0.0",
+ "ajv": "^5.0.0",
kzar 2019/01/22 16:04:47 (I have not looked into this ajv dependency, or ch
tlucas 2019/01/22 16:08:00 Quoting cron: "npm WARN ajv-keywords@2.1.1 require
"jsdoc": "3.5.5",
"manifoldjs": "0.7.6",
"memory-fs": "0.4.1",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld