Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29990555: Issue 7179 - Add function to return all matching filters (Closed)

Created:
Jan. 25, 2019, 12:14 p.m. by Manish Jethani
Modified:
Jan. 28, 2019, 10:45 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add JSDoc for collection parameter #

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -3 lines) Patch
M lib/matcher.js View 1 2 4 chunks +107 lines, -3 lines 0 comments Download
M test/matcher.js View 2 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Manish Jethani
Jan. 25, 2019, 12:14 p.m. (2019-01-25 12:14:17 UTC) #1
Manish Jethani
Patch Set 1 This is a little bit different from what I have mentioned in ...
Jan. 25, 2019, 12:19 p.m. (2019-01-25 12:19:30 UTC) #2
hub
https://codereview.adblockplus.org/29990555/diff/29990556/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/29990555/diff/29990556/lib/matcher.js#newcode303 lib/matcher.js:303: * @param {Array.<Filter>} collection I think this parameter deserve ...
Jan. 25, 2019, 8:52 p.m. (2019-01-25 20:52:57 UTC) #3
Manish Jethani
Patch Set 2: Add JSDoc for collection parameter Patch Set 3: Fix typo
Jan. 28, 2019, 5:36 p.m. (2019-01-28 17:36:07 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29990555/diff/29990556/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/29990555/diff/29990556/lib/matcher.js#newcode303 lib/matcher.js:303: * @param {Array.<Filter>} collection On 2019/01/25 20:52:57, hub wrote: ...
Jan. 28, 2019, 5:37 p.m. (2019-01-28 17:37:08 UTC) #5
hub
Jan. 28, 2019, 8:38 p.m. (2019-01-28 20:38:04 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld