Issue 29991555: Issue 7085 - Use newer eslint-config-eyeo and eslint

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29991555: Issue 7085 - Use newer eslint-config-eyeo and eslint (Closed)

Created:
Jan. 28, 2019, 1:33 p.m. by hub

Modified:
Jan. 28, 2019, 2:32 p.m.

Reviewers:
tlucas, Manish Jethani

CC:
Erik

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Issue 7085 - Use newer eslint-config-eyeo and eslint

Patch Set 1 #

Total comments: 2

Created: Jan. 28, 2019, 1:33 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	package.json	View		1 chunk	+3 lines, -3 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hub

https://codereview.adblockplus.org/29991555/diff/29991556/package.json File package.json (right): https://codereview.adblockplus.org/29991555/diff/29991556/package.json#newcode10 package.json:10: "eslint": "^5.1.0", we need a more recent version too. ...

Jan. 28, 2019, 1:35 p.m. (2019-01-28 13:35:45 UTC) #2

tlucas

Jan. 28, 2019, 1:43 p.m. (2019-01-28 13:43:05 UTC) #3

On 2019/01/28 13:35:45, hub wrote:
> https://codereview.adblockplus.org/29991555/diff/29991556/package.json
> File package.json (right):
> 
>
https://codereview.adblockplus.org/29991555/diff/29991556/package.json#newcode10
> package.json:10: "eslint": "^5.1.0",
> we need a more recent version too. This is the one used in the WebExtension
> 
>
https://codereview.adblockplus.org/29991555/diff/29991556/package.json#newcode24
> package.json:24: "eslint": "eslint *.js lib test build",
> the `chrome` directory no longer has any .js and eslint complain about it.

LGTM

Expand All Messages | Collapse All Messages