Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: qunit/tests/url.js

Issue 29991594: Issue 7243 - Update adblockpluscore dependency to hg:e26e122e0702 (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Update dependency to hg:91cd83c4c272 Created Jan. 30, 2019, 7:19 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/devtools.js ('K') | « metadata.chrome ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: qunit/tests/url.js
===================================================================
--- a/qunit/tests/url.js
+++ b/qunit/tests/url.js
@@ -13,17 +13,18 @@
*
* You should have received a copy of the GNU General Public License
* along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
*/
"use strict";
{
- const {extractHostFromFrame, isThirdParty} = require("../../lib/url");
+ const {isThirdParty} = require("../../adblockpluscore/lib/domain");
Sebastian Noack 2019/01/30 19:54:25 Shouldn't we rather remove the isThridParty() chec
Manish Jethani 2019/01/31 01:04:14 Done.
+ const {extractHostFromFrame} = require("../../lib/url");
const {platform} = require("info");
QUnit.module("URL/host tools");
test("Extracting hostname from frame", () =>
{
function testFrameHostname(hierarchy, expectedHostname, message)
{
« lib/devtools.js ('K') | « metadata.chrome ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld