Noissue - Work around N812 and E117 from flake8 update

Noissue - work around N812 errors from flake8 update

Repository: https://hg.adblockplus.org/python-abp
Base revision: 199cda9f1098

[Vasily Kuznetsov, 2019-01-29 16:37:24]

Hi Rosie!

While reviewing your other commit I have noticed that the "flake8" environment
currently fails for python-abp because of these lines:

    import http.server as SimpleHTTPServer
    import socketserver as SocketServer

This patch fixes it kind of hackily but I'm not sure if there's a better way.
What do you think?

Cheers,
Vasily

[rhowell, 2019-01-29 20:28:40]

Hi Vasily!

I noticed this issue too, thanks for fixing it! Just one comment, see below. I
don't feel too strongly about it, both are viable options. What do you think?

https://codereview.adblockplus.org/29992563/diff/29992564/tests/test_render_s...
File tests/test_render_script.py (right):

https://codereview.adblockplus.org/29992563/diff/29992564/tests/test_render_s...
tests/test_render_script.py:35: SimpleHTTPServer, SocketServer = server,
socketserver
Just curious, why not do it in 2 lines instead of 3?  E.g.

    from http import server as SimpleHTTPServer  # noqa: N812
    import socketserver as SocketServer  # noqa: N812

This way, we're more explicit in acknowledging the linter error, we save a line,
and it seems _slightly_ more readable to me. This method also seems consistent
with how some other popular projects handle similar situations (e.g.
https://github.com/pypa/pip/blob/master/src/pip/_internal/utils/hashes.py#L14).

[Vasily Kuznetsov, 2019-01-30 10:42:48]

Hi Rosie,

Thanks for the suggestion, I have used it.

Meanwhile pycodestyle released an update that generated another error -- I have
fixed that one too.

Cheers,
Vasily

https://codereview.adblockplus.org/29992563/diff/29992564/tests/test_render_s...
File tests/test_render_script.py (right):

https://codereview.adblockplus.org/29992563/diff/29992564/tests/test_render_s...
tests/test_render_script.py:35: SimpleHTTPServer, SocketServer = server,
socketserver
On 2019/01/29 20:28:39, rhowell wrote:
> Just curious, why not do it in 2 lines instead of 3?  E.g.
> 
>     from http import server as SimpleHTTPServer  # noqa: N812
>     import socketserver as SocketServer  # noqa: N812
> 
> This way, we're more explicit in acknowledging the linter error, we save a
line,
> and it seems _slightly_ more readable to me. This method also seems consistent
> with how some other popular projects handle similar situations (e.g.
>
https://github.com/pypa/pip/blob/master/src/pip/_internal/utils/hashes.py#L14).

I was trying to avoid disabling the linter. But all in all, my code is working
around the linter anyway, so we might as well be honest and mark it explicitly.
I'll go with your version.

https://codereview.adblockplus.org/29992563/diff/29993565/abp/filters/rpy.py
File abp/filters/rpy.py (right):

https://codereview.adblockplus.org/29992563/diff/29993565/abp/filters/rpy.py#...
abp/filters/rpy.py:70: # The condition is a Python 2/3 way of saying "unicode
string".
Reformatted this to avoid E117.

[rhowell, 2019-01-30 16:18:47]

On 2019/01/30 10:42:48, Vasily Kuznetsov wrote:
> Hi Rosie,
> 
> Thanks for the suggestion, I have used it.
> 
> Meanwhile pycodestyle released an update that generated another error -- I
have
> fixed that one too.
> 
> Cheers,
> Vasily
> 
>
https://codereview.adblockplus.org/29992563/diff/29992564/tests/test_render_s...
> File tests/test_render_script.py (right):
> 
>
https://codereview.adblockplus.org/29992563/diff/29992564/tests/test_render_s...
> tests/test_render_script.py:35: SimpleHTTPServer, SocketServer = server,
> socketserver
> On 2019/01/29 20:28:39, rhowell wrote:
> > Just curious, why not do it in 2 lines instead of 3?  E.g.
> > 
> >     from http import server as SimpleHTTPServer  # noqa: N812
> >     import socketserver as SocketServer  # noqa: N812
> > 
> > This way, we're more explicit in acknowledging the linter error, we save a
> line,
> > and it seems _slightly_ more readable to me. This method also seems
consistent
> > with how some other popular projects handle similar situations (e.g.
> >
>
https://github.com/pypa/pip/blob/master/src/pip/_internal/utils/hashes.py#L14).
> 
> I was trying to avoid disabling the linter. But all in all, my code is working
> around the linter anyway, so we might as well be honest and mark it
explicitly.
> I'll go with your version.
> 
> https://codereview.adblockplus.org/29992563/diff/29993565/abp/filters/rpy.py
> File abp/filters/rpy.py (right):
> 
>
https://codereview.adblockplus.org/29992563/diff/29993565/abp/filters/rpy.py#...
> abp/filters/rpy.py:70: # The condition is a Python 2/3 way of saying "unicode
> string".
> Reformatted this to avoid E117.

LGTM