Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29994568: Noissue - Use flake8's built-in per-file-ignores instead of flake8-per-file-ignores (Closed)

Created:
Jan. 31, 2019, 11 p.m. by rhowell
Modified:
Feb. 7, 2019, 4:19 a.m.
Base URL:
https://hg.adblockplus.org/abpssembly
Visibility:
Public.

Description

Noissue - Use flake8's built-in per-file-ignores instead of flake8-per-file-ignores Repository: https://hg.adblockplus.org/abpssembly Base revision: 845ae7cabd63

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -68 lines) Patch
M .hgignore View 1 chunk +1 line, -0 lines 2 comments Download
M tox.ini View 3 chunks +68 lines, -68 lines 0 comments Download

Messages

Total messages: 10
rhowell
Jan. 31, 2019, 11 p.m. (2019-01-31 23:00:06 UTC) #1
rhowell
Hey guys, I had to add some new per-file-ignores, and wanted to make sure we're ...
Jan. 31, 2019, 11:01 p.m. (2019-01-31 23:01:04 UTC) #2
tlucas
Hey Rosie! I wouldn't know why i would mind reviewing. I initially wanted to also ...
Jan. 31, 2019, 11:15 p.m. (2019-01-31 23:15:44 UTC) #3
Vasily Kuznetsov
Hi Rosie, Thank you for taking care of this. I think we should also ignore ...
Feb. 1, 2019, 3:07 p.m. (2019-02-01 15:07:40 UTC) #4
Vasily Kuznetsov
> https://codereview.adblockplus.org/29994568/diff/29994569/.hgignore#newcode9 > .hgignore:9: .pytest_cache > It seems that this line is already there, although ...
Feb. 1, 2019, 3:13 p.m. (2019-02-01 15:13:14 UTC) #5
rhowell
On 2019/02/01 15:13:14, Vasily Kuznetsov wrote: > > https://codereview.adblockplus.org/29994568/diff/29994569/.hgignore#newcode9 > > .hgignore:9: .pytest_cache > > ...
Feb. 2, 2019, 2:38 a.m. (2019-02-02 02:38:04 UTC) #6
Vasily Kuznetsov
On 2019/02/02 02:38:04, rhowell wrote: > On 2019/02/01 15:13:14, Vasily Kuznetsov wrote: > > > ...
Feb. 4, 2019, 1:54 p.m. (2019-02-04 13:54:21 UTC) #7
tlucas
On 2019/02/04 13:54:21, Vasily Kuznetsov wrote: > I think having both errors ignored would be ...
Feb. 4, 2019, 2:02 p.m. (2019-02-04 14:02:24 UTC) #8
Vasily Kuznetsov
Ah, yeah, LGTM from me too!
Feb. 4, 2019, 2:48 p.m. (2019-02-04 14:48:23 UTC) #9
rhowell
Feb. 5, 2019, 1:35 a.m. (2019-02-05 01:35:28 UTC) #10
On 2019/02/04 14:48:23, Vasily Kuznetsov wrote:
> Ah, yeah, LGTM from me too!

Great, thanks! It seems I don't have push access to this repo. Could someone
push this for me? Or should I request access from ops?

Powered by Google App Engine
This is Rietveld