Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29994572: Noissue - Use flake8's built-in per-file-ignores instead of flake8-per-file-ignores (Closed)

Created:
Jan. 31, 2019, 11:31 p.m. by rhowell
Modified:
Feb. 2, 2019, 2:57 a.m.
Reviewers:
Vasily Kuznetsov
Base URL:
https://hg.adblockplus.org/sitescripts/
Visibility:
Public.

Description

Noissue - Use flake8's built-in per-file-ignores instead of flake8-per-file-ignores Repository: https://hg.adblockplus.org/sitescripts Base revision: 5cccbbe6bc8d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -60 lines) Patch
M sitescripts/formmail/web/formmail.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tox.ini View 2 chunks +58 lines, -58 lines 0 comments Download

Messages

Total messages: 3
rhowell
Jan. 31, 2019, 11:31 p.m. (2019-01-31 23:31:28 UTC) #1
rhowell
Hi Vasily! This is mostly all the same changes that were made to abpssembly, except ...
Jan. 31, 2019, 11:31 p.m. (2019-01-31 23:31:54 UTC) #2
Vasily Kuznetsov
Feb. 1, 2019, 3:31 p.m. (2019-02-01 15:31:22 UTC) #3
On 2019/01/31 23:31:54, rhowell wrote:
> Hi Vasily!
> 
> This is mostly all the same changes that were made to abpssembly, except for
the
> formmail flake8 error - those lines really were over-indented, so I just fixed
> that one, but the rest of the flake8 errors were all complaining about
> mixed-case variables. The full list is here: https://pastebin.com/C6P6JxRx
> 
> Let me know if you see any issues?
> 
> Thanks!  :)
> Rosie

Maybe that indentation should be a separate noissue, but I'd say it's too small,
so unless you want to do it, it's ok as is. LGTM

Powered by Google App Engine
This is Rietveld