Issue 29994572: Noissue - Use flake8's built-in per-file-ignores instead of flake8-per-file-ignores

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29994572: Noissue - Use flake8's built-in per-file-ignores instead of flake8-per-file-ignores (Closed)

Created:
Jan. 31, 2019, 11:31 p.m. by rhowell

Modified:
Feb. 2, 2019, 2:57 a.m.

Reviewers:
Vasily Kuznetsov

Base URL:
https://hg.adblockplus.org/sitescripts/

Visibility:
Public.

Description

Noissue - Use flake8's built-in per-file-ignores instead of flake8-per-file-ignores Repository: https://hg.adblockplus.org/sitescripts Base revision: 5cccbbe6bc8d

Patch Set 1 #

Created: Jan. 31, 2019, 11:31 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -60 lines)			Patch
	M	sitescripts/formmail/web/formmail.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tox.ini	View		2 chunks	+58 lines, -58 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rhowell

Hi Vasily! This is mostly all the same changes that were made to abpssembly, except ...

Jan. 31, 2019, 11:31 p.m. (2019-01-31 23:31:54 UTC) #2

Vasily Kuznetsov

Feb. 1, 2019, 3:31 p.m. (2019-02-01 15:31:22 UTC) #3

On 2019/01/31 23:31:54, rhowell wrote:
> Hi Vasily!
> 
> This is mostly all the same changes that were made to abpssembly, except for
the
> formmail flake8 error - those lines really were over-indented, so I just fixed
> that one, but the rest of the flake8 errors were all complaining about
> mixed-case variables. The full list is here: https://pastebin.com/C6P6JxRx
> 
> Let me know if you see any issues?
> 
> Thanks!  :)
> Rosie

Maybe that indentation should be a separate noissue, but I'd say it's too small,
so unless you want to do it, it's ok as is. LGTM

Expand All Messages | Collapse All Messages