Noissue - Use flake8's built-in per-file-ignores and work around pep8-naming bug

Noissue - Use flake8's built-in per-file-ignores and work around pep8-naming bug

Repository: https://hg.adblockplus.org/cms
Base revision: 48798fda011c

[rhowell, 2019-02-01 00:13:08]

Hey guys!

I ran into a bug while working on this - it seems pep8-naming released a new
version (0.8.0) on Jan 28, and it seems to have reintroduced a bug similar to
this one: https://github.com/PyCQA/pep8-naming/issues/53

I found at least one file that breaks pep8-naming,
cms/translations/xtm/projects_handler.py.
I was able to reproduce it in a virtualenv, results are here:
https://pastebin.com/h2yTktQJ

Wondering the best way to proceed. For now, keeping pep8-naming<=0.7.0 works,
but maybe we should file a bug report with them? Should this be a separate
Noissue commit?

And let me know if you see any other issues?

Thanks!  :)
Rosie

[Vasily Kuznetsov, 2019-02-01 16:00:29]

On 2019/02/01 00:13:08, rhowell wrote:
> Hey guys!
> 
> I ran into a bug while working on this - it seems pep8-naming released a new
> version (0.8.0) on Jan 28, and it seems to have reintroduced a bug similar to
> this one: https://github.com/PyCQA/pep8-naming/issues/53
> 
> I found at least one file that breaks pep8-naming,
> cms/translations/xtm/projects_handler.py.
> I was able to reproduce it in a virtualenv, results are here:
> https://pastebin.com/h2yTktQJ
> 
> Wondering the best way to proceed. For now, keeping pep8-naming<=0.7.0 works,
> but maybe we should file a bug report with them? Should this be a separate
> Noissue commit?
> 
> And let me know if you see any other issues?
> 
> Thanks!  :)
> Rosie

Hi Rosie,

I think it would be nice to separate the pep8-naming version pin into a separate
commit, but it also seems too small of a change. Perhaps you can just add
another line to the commit message here to mention why it got pinned.

LGTM

Cheers,
Vasily