Issue 29994580: Noissue - Don't use long name in Microsoft Edge release builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29994580: Noissue - Don't use long name in Microsoft Edge release builds (Closed)

Created:
Feb. 1, 2019, 1:13 a.m. by Sebastian Noack

Modified:
Feb. 1, 2019, 1:19 a.m.

Reviewers:
tlucas

CC:
wspee

Visibility:
Public.

Description

Noissue - Don't use long name in Microsoft Edge release builds

Patch Set 1 #

Created: Feb. 1, 2019, 1:13 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -7 lines)			Patch
M	templates/manifest.json.tmpl	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/expecteddata/AppxManifest_edge_release_build.xml	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/expecteddata/manifest_edge_devenv.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/expecteddata/manifest_edge_release_build.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Sebastian Noack

As discussed with Winsley, we merely changed the name to "Adblock Plus - free ad ...

Feb. 1, 2019, 1:16 a.m. (2019-02-01 01:16:13 UTC) #1

tlucas

Feb. 1, 2019, 1:17 a.m. (2019-02-01 01:17:39 UTC) #2

On 2019/02/01 01:16:13, Sebastian Noack wrote:
> As discussed with Winsley, we merely changed the name to "Adblock Plus - free
ad
> blocker" for the stores. However, the name shown on the Microsoft Store is
> unrelated of the name given in the package. So we are going to revert the name
> change for Microsoft Edge (only).

Sounds sane, LGTM

Expand All Messages | Collapse All Messages