Noissue - Use flake8's built-in per-file-ignores instead of flake8-per-file-ignores

Noissue - Use flake8's built-in per-file-ignores instead of flake8-per-file-ignores

[rhowell, 2019-02-01 01:35:09]

Hey guys,

After switching to flake8's per-file-ignores, a few more flake8 errors were
caught. I just added them as per-file-ignores.

W504 (line break after binary operator) showed up a few times. We had discussed
ignoring W504 in flake8-eyeo instead
(https://issues.adblockplus.org/ticket/7196) but since that's not ready yet, I
just ignored it here.

There were some other complaints about comparing str, bytes, and int literals,
and the rest were about mixed-case variables. If you want to check out the
errors, they're here: https://pastebin.com/y2wKTe5r

Let me know if you think this is the best approach, or if you see any other
issues?

Thanks!  :)
Rosie

[Sebastian Noack, 2019-02-01 03:13:12]

On 2019/02/01 01:35:09, rhowell wrote:
> Hey guys,
> 
> After switching to flake8's per-file-ignores, a few more flake8 errors were
> caught. I just added them as per-file-ignores.
> 
> W504 (line break after binary operator) showed up a few times. We had
discussed
> ignoring W504 in flake8-eyeo instead
> (https://issues.adblockplus.org/ticket/7196) but since that's not ready yet, I
> just ignored it here.
> 
> There were some other complaints about comparing str, bytes, and int literals,
> and the rest were about mixed-case variables. If you want to check out the
> errors, they're here: https://pastebin.com/y2wKTe5r
> 
> Let me know if you think this is the best approach, or if you see any other
> issues?
> 
> Thanks!  :)
> Rosie

The E117, F632, and N8 errors are new but they seem to make sense. So I agree
adding them to the per-file-ignores.

However, for W503 and W504 see the discussion in
https://issues.adblockplus.org/ticket/7196. As we already had them before this
change, I would leave them alone here. But if you want you can submit a separate
patch ignoring W503 and W504 everywhere as this was what we agreed on in issue
7196.

[rhowell, 2019-02-01 04:44:14]

On 2019/02/01 03:13:12, Sebastian Noack wrote:

> However, for W503 and W504 see the discussion in
> https://issues.adblockplus.org/ticket/7196. As we already had them before this
> change, I would leave them alone here. But if you want you can submit a
separate
> patch ignoring W503 and W504 everywhere as this was what we agreed on in issue
> 7196.

As I mentioned above, 7196 hasn't been marked ready yet, that's why I figured I
would just do it here. But, if 7196 will be ready soon, then I'll certainly do
it that way instead.

[Sebastian Noack, 2019-02-01 05:01:12]

On 2019/02/01 04:44:14, rhowell wrote:
> As I mentioned above, 7196 hasn't been marked ready yet, that's why I figured
I
> would just do it here. But, if 7196 will be ready soon, then I'll certainly do
> it that way instead.

Well, it's an unrelated change. But whatever, it's not worth to argue. LGTM.