Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 29998582: Issue [TBD] - Update adblockpluscore dependency to [TBD]

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 3 weeks ago by Manish Jethani
Modified:
3 months, 2 weeks ago
Reviewers:
Sebastian Noack
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Based on https://codereview.adblockplus.org/29998564/

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove matchRequest #

Total comments: 2

Patch Set 3 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -51 lines) Patch
M lib/csp.js View 1 2 1 chunk +16 lines, -17 lines 0 comments Download
M lib/devtools.js View 1 chunk +0 lines, -1 line 0 comments Download
M lib/filterComposer.js View 2 chunks +1 line, -3 lines 0 comments Download
M lib/popupBlocker.js View 2 chunks +2 lines, -4 lines 0 comments Download
M lib/requestBlocker.js View 1 6 chunks +10 lines, -19 lines 0 comments Download
M lib/whitelisting.js View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 8
Manish Jethani
3 months, 3 weeks ago (2019-02-05 04:08:00 UTC) #1
Manish Jethani
Patch Set 1 Companion patch for https://codereview.adblockplus.org/29998564/ I will file tickets.
3 months, 3 weeks ago (2019-02-05 04:12:53 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js File lib/csp.js (left): https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js#oldcode67 lib/csp.js:67: }, cspMatch); Nit: It seems this could be wrapped ...
3 months, 3 weeks ago (2019-02-05 04:41:43 UTC) #3
Manish Jethani
Patch Set 2: Remove matchRequest https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js File lib/csp.js (left): https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js#oldcode67 lib/csp.js:67: }, cspMatch); On 2019/02/05 ...
3 months, 3 weeks ago (2019-02-05 05:16:20 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29998582/diff/29999555/lib/csp.js File lib/csp.js (left): https://codereview.adblockplus.org/29998582/diff/29999555/lib/csp.js#oldcode74 lib/csp.js:74: "blocking"); Nit: The last argument can go on the ...
3 months, 3 weeks ago (2019-02-05 05:23:17 UTC) #5
Manish Jethani
Patch Set 3: Reformat https://codereview.adblockplus.org/29998582/diff/29999555/lib/csp.js File lib/csp.js (left): https://codereview.adblockplus.org/29998582/diff/29999555/lib/csp.js#oldcode74 lib/csp.js:74: "blocking"); On 2019/02/05 05:23:17, Sebastian ...
3 months, 3 weeks ago (2019-02-05 05:45:49 UTC) #6
Sebastian Noack
The changes look good to me, once the dependency update is in.
3 months, 3 weeks ago (2019-02-05 05:55:39 UTC) #7
Manish Jethani
3 months, 2 weeks ago (2019-02-05 06:24:38 UTC) #8
On 2019/02/05 05:55:39, Sebastian Noack wrote:
> The changes look good to me, once the dependency update is in.

OK.

As I mentioned on the other review [1], let's put this on hold until after code
freeze for ABP 3.5. I am not sure it actually helps in performance. If we are
doing it for other reasons, we should do it a bit more patiently. I would like
to properly test the change in Core and make it's implemented in the best
possible way (as well as try out your suggestion of avoiding the call for most
requests).

Let me put it this way: if I don't come up with a way to make this change _also_
benefit performance (by avoiding unnecessary calls to isThirdParty) by the end
of the day, let's postpone it for now.

[1]: https://codereview.adblockplus.org/29998564/#msg10
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5