Issue [TBD] - Update adblockpluscore dependency to [TBD]

Based on https://codereview.adblockplus.org/29998564/

[Manish Jethani, 2019-02-05 04:12:53]

Patch Set 1

Companion patch for https://codereview.adblockplus.org/29998564/

I will file tickets.

[Sebastian Noack, 2019-02-05 04:41:43]

https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js
File lib/csp.js (left):

https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js#oldcode67
lib/csp.js:67: }, cspMatch);
Nit: It seems this could be wrapped more readable like this now:

  logRequest(
    [details.tabId],
    {url: details.url, type: "CSP", docDomain: hostname, specificOnly},
    cspMatch
  );

https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js#oldcode80
lib/csp.js:80: }, cspMatch);
Nit: Same as above.

https://codereview.adblockplus.org/29998582/diff/29998583/lib/requestBlocker.js
File lib/requestBlocker.js (left):

https://codereview.adblockplus.org/29998582/diff/29998583/lib/requestBlocker....
lib/requestBlocker.js:91: function matchRequest(url, type, docDomain, sitekey,
specificOnly)
With the third-party check removed, keeping this helper function around seems
unnecessary. What is left is just passing the arguments through to
defaultMatcher.matchesAny(). I'd rather call defaultMatcher.matchesAny()
directly now.

[Manish Jethani, 2019-02-05 05:16:20]

Patch Set 2: Remove matchRequest

https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js
File lib/csp.js (left):

https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js#oldcode67
lib/csp.js:67: }, cspMatch);
On 2019/02/05 04:41:43, Sebastian Noack wrote:
> Nit: It seems this could be wrapped more readable like this now:
> 
>   logRequest(
>     [details.tabId],
>     {url: details.url, type: "CSP", docDomain: hostname, specificOnly},
>     cspMatch
>   );

Done.

https://codereview.adblockplus.org/29998582/diff/29998583/lib/csp.js#oldcode80
lib/csp.js:80: }, cspMatch);
On 2019/02/05 04:41:43, Sebastian Noack wrote:
> Nit: Same as above.

Done.

https://codereview.adblockplus.org/29998582/diff/29998583/lib/requestBlocker.js
File lib/requestBlocker.js (left):

https://codereview.adblockplus.org/29998582/diff/29998583/lib/requestBlocker....
lib/requestBlocker.js:91: function matchRequest(url, type, docDomain, sitekey,
specificOnly)
On 2019/02/05 04:41:43, Sebastian Noack wrote:
> With the third-party check removed, keeping this helper function around seems
> unnecessary. What is left is just passing the arguments through to
> defaultMatcher.matchesAny(). I'd rather call defaultMatcher.matchesAny()
> directly now.

Done.

[Sebastian Noack, 2019-02-05 05:23:17]

https://codereview.adblockplus.org/29998582/diff/29999555/lib/csp.js
File lib/csp.js (left):

https://codereview.adblockplus.org/29998582/diff/29999555/lib/csp.js#oldcode74
lib/csp.js:74: "blocking");
Nit: The last argument can go on the above line now.

[Manish Jethani, 2019-02-05 05:45:49]

Patch Set 3: Reformat

https://codereview.adblockplus.org/29998582/diff/29999555/lib/csp.js
File lib/csp.js (left):

https://codereview.adblockplus.org/29998582/diff/29999555/lib/csp.js#oldcode74
lib/csp.js:74: "blocking");
On 2019/02/05 05:23:17, Sebastian Noack wrote:
> Nit: The last argument can go on the above line now.

Done.

[Sebastian Noack, 2019-02-05 05:55:39]

The changes look good to me, once the dependency update is in.

[Manish Jethani, 2019-02-05 06:24:38]

On 2019/02/05 05:55:39, Sebastian Noack wrote:
> The changes look good to me, once the dependency update is in.

OK.

As I mentioned on the other review [1], let's put this on hold until after code
freeze for ABP 3.5. I am not sure it actually helps in performance. If we are
doing it for other reasons, we should do it a bit more patiently. I would like
to properly test the change in Core and make it's implemented in the best
possible way (as well as try out your suggestion of avoiding the call for most
requests).

Let me put it this way: if I don't come up with a way to make this change _also_
benefit performance (by avoiding unnecessary calls to isThirdParty) by the end
of the day, let's postpone it for now.

[1]: https://codereview.adblockplus.org/29998564/#msg10