Noissue - Use suffixes function

lib/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 153 matching lines @@
  *   be included.
  *
  * @returns {Array.<string>} The list of selectors.
  */
 function getConditionalSelectors(domain, specificOnly)
 {
   let selectors = [];
 
   let excluded = new Set();
 
-  // This code is a performance hot-spot, which is why we've made certain
-  // micro-optimisations. Please be careful before making changes.
   for (let currentDomain of suffixes(domain, !specificOnly))

[hub, 2019/02/06 12:55:05]

I assume that this change doesn't cause a performance regression since this
section is labelled as being a hot spot?

[Manish Jethani, 2019/02/06 13:13:31]

This is no longer a hot spot and in fact this comment is misleading. I think we
should remove this comment. There is nothing special about this function, there
are lots of such functions where we have done optimizations.

[Manish Jethani, 2019/02/06 13:17:06]

Done.

   {
     let filters = filtersByDomain.get(currentDomain);
     if (filters)
     {
       for (let [filter, isIncluded] of filters)
       {
         if (!isIncluded)
         {
           excluded.add(filter);
         }
@@ skipping 321 matching lines @@
 {
   let styleSheet = "";
 
   for (let selectorGroup of splitSelectors(selectors))
     styleSheet += createRule(selectorGroup);
 
   return styleSheet;
 }
 
 exports.createStyleSheet = createStyleSheet;