Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29999569: Noissue - Use suffixes function (Closed)

Created:
Feb. 5, 2019, 3:19 p.m. by Manish Jethani
Modified:
Feb. 6, 2019, 1:40 p.m.
Reviewers:
hub
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove misleading comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M lib/domain.js View 1 chunk +9 lines, -1 line 0 comments Download
M lib/elemHide.js View 1 3 chunks +2 lines, -13 lines 0 comments Download
M lib/filterClasses.js View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7
Manish Jethani
Feb. 5, 2019, 3:19 p.m. (2019-02-05 15:19:43 UTC) #1
Manish Jethani
Patch Set 1
Feb. 5, 2019, 3:21 p.m. (2019-02-05 15:21:50 UTC) #2
Manish Jethani
Patch Set 1
Feb. 5, 2019, 3:22 p.m. (2019-02-05 15:22:10 UTC) #3
hub
LGTM https://codereview.adblockplus.org/29999569/diff/29999570/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29999569/diff/29999570/lib/elemHide.js#newcode176 lib/elemHide.js:176: for (let currentDomain of suffixes(domain, !specificOnly)) I assume ...
Feb. 6, 2019, 12:55 p.m. (2019-02-06 12:55:06 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29999569/diff/29999570/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29999569/diff/29999570/lib/elemHide.js#newcode176 lib/elemHide.js:176: for (let currentDomain of suffixes(domain, !specificOnly)) On 2019/02/06 12:55:05, ...
Feb. 6, 2019, 1:13 p.m. (2019-02-06 13:13:32 UTC) #5
Manish Jethani
Patch Set 2: Remove misleading comment https://codereview.adblockplus.org/29999569/diff/29999570/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29999569/diff/29999570/lib/elemHide.js#newcode176 lib/elemHide.js:176: for (let currentDomain ...
Feb. 6, 2019, 1:17 p.m. (2019-02-06 13:17:06 UTC) #6
hub
Feb. 6, 2019, 1:34 p.m. (2019-02-06 13:34:41 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld