Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 30000594: Noissue - Check domains first for regular expression filters (Closed)

Feb. 6, 2019, 4:57 p.m. by Manish Jethani
Feb. 6, 2019, 7:22 p.m.
Sebastian Noack
Base URL:


Following up on https://hg.adblockplus.org/adblockpluscore/rev/3ab884752712 Sebastian points out that sometimes there can be domain-specific regular expression filters that are too complex and cause the browser to hang. It is for this reason that the document's domain was being checked before the request URL. This patch is a compromise where we have the best of both: for regular expression filters we check the document's domain first (safety), for other filters we check the request URL first (performance).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M lib/filterClasses.js View 1 chunk +4 lines, -2 lines 0 comments Download


Total messages: 3
Manish Jethani
Feb. 6, 2019, 4:57 p.m. (2019-02-06 16:57:20 UTC) #1
Manish Jethani
Patch Set 1 Performance is OK with this.
Feb. 6, 2019, 5:02 p.m. (2019-02-06 17:02:00 UTC) #2
Sebastian Noack
Feb. 6, 2019, 7:02 p.m. (2019-02-06 19:02:42 UTC) #3

Powered by Google App Engine
This is Rietveld