Issue 30002595: Issue 7196 - Ignore both flake8 W503 and W504 in tox.ini

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30002595: Issue 7196 - Ignore both flake8 W503 and W504 in tox.ini (Closed)

Created:
Feb. 8, 2019, 11:54 p.m. by rhowell

Modified:
March 2, 2019, 3:32 a.m.

Reviewers:
Vasily Kuznetsov

Base URL:
https://hg.adblockplus.org/sitescripts/

Visibility:
Public.

Description

Issue 7196 - Ignore both flake8 W503 and W504 in tox.ini Repository: https://hg.adblockplus.org/sitescripts Base revision: 290e6b212c9f

Patch Set 1 #

Created: Feb. 8, 2019, 11:54 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	tox.ini	View		3 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rhowell

Hey Vasily, If it's alright, I can change the issue to something like 'Ignore both ...

Feb. 8, 2019, 11:55 p.m. (2019-02-08 23:55:04 UTC) #2

Vasily Kuznetsov

Feb. 11, 2019, 4:22 p.m. (2019-02-11 16:22:40 UTC) #3

On 2019/02/08 23:55:04, rhowell wrote:
> Hey Vasily,
> 
> If it's alright, I can change the issue to something like 'Ignore both flake8
> W503 and W504 in tox.ini'. Or do you think that ticket should just be closed? 
> https://issues.adblockplus.org/ticket/7196

Hi Rosie!

I think updating the ticket to ignore things in tox.ini is useful to make it
clear how that was resolved.

This change LGTM.

Cheers,
Vasily

Expand All Messages | Collapse All Messages