Issue 30002598: Issue 7196 - Ignore both flake8 W503 and W504 in tox.ini

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30002598: Issue 7196 - Ignore both flake8 W503 and W504 in tox.ini (Closed)

Created:
Feb. 9, 2019, 12:03 a.m. by rhowell

Modified:
Feb. 27, 2019, 10:23 p.m.

Reviewers:
Vasily Kuznetsov

Base URL:
https://hg.adblockplus.org/python-abp

Visibility:
Public.

Description

Issue 7196 - Ignore both flake8 W503 and W504 in tox.ini Repository: https://hg.adblockplus.org/python-abp Base revision: 7ff02fd79223

Patch Set 1 #

Created: Feb. 9, 2019, 12:03 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tox.ini	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rhowell

Hey Vasily! Couple questions: 1. Is this change too small to be it's own commit? ...

Feb. 9, 2019, 12:07 a.m. (2019-02-09 00:07:57 UTC) #2

Vasily Kuznetsov

Feb. 11, 2019, 4:15 p.m. (2019-02-11 16:15:36 UTC) #3

Hi Rosie!

LGTM

> 1. Is this change too small to be it's own commit? It is rather small, but
then
> at least tox will stop flagging W504 going forward.

No change is too small ;)

> 2. Should I update #7196 to align with these tox.ini changes, or just make
these
> Noissues?

I think mentioning in the description of #7196 that we've decided to ignore the
errors in the repositories that have ignores (those that don't have ignores
don't need it because ignoring both W504 and W503 is the default) instead of
flake8-eyeo would be useful.

Cheers,
Vasily

Expand All Messages | Collapse All Messages