Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browser/elemHideEmulation.js

Issue 30002601: Issue 7284 - Move CSS escaping to createStyleSheet (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Reworked the escaping of selectors Created Feb. 12, 2019, 11:50 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/browser/elemHideEmulation.js
===================================================================
--- a/test/browser/elemHideEmulation.js
+++ b/test/browser/elemHideEmulation.js
@@ -297,38 +297,16 @@
let selectors = [":-abp-properties(/.*color: rgb\\(0, 0, 0\\)/)"];
if (await applyElemHideEmulation(test, selectors))
expectHidden(test, toHide);
test.done();
};
-exports.testPropertySelectorWithEscapedBrace = async function(test)
hub 2019/02/12 23:55:49 these two tests are no longer relevant.
Manish Jethani 2019/02/13 12:27:25 Shouldn't we add some tests now to test/elemHide.j
hub 2019/02/13 16:33:32 Yes
-{
- let toHide = createElementWithStyle("{background-color: #000}");
- let selectors = [":-abp-properties(/background.\\7B 0,6\\7D : rgb\\(0, 0, 0\\)/)"];
-
- if (await applyElemHideEmulation(test, selectors))
- expectHidden(test, toHide);
-
- test.done();
-};
-
-exports.testPropertySelectorWithImproperlyEscapedBrace = async function(test)
-{
- let toHide = createElementWithStyle("{background-color: #000}");
- let selectors = [":-abp-properties(/background.\\7B0,6\\7D: rgb\\(0, 0, 0\\)/)"];
-
- if (await applyElemHideEmulation(test, selectors))
- expectVisible(test, toHide);
-
- test.done();
-};
-
exports.testDynamicallyChangedProperty = async function(test)
{
let toHide = createElementWithStyle("{}");
let selectors = [":-abp-properties(background-color: rgb(0, 0, 0))"];
if (await applyElemHideEmulation(test, selectors))
{
expectVisible(test, toHide);

Powered by Google App Engine
This is Rietveld