Issue 30009560: Noissue - Rename lib/domain.js to lib/url.js

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30009560: Noissue - Rename lib/domain.js to lib/url.js (Closed)

Created:
Feb. 16, 2019, 12:42 p.m. by Manish Jethani

Modified:
Feb. 19, 2019, 6:09 p.m.

Reviewers:
hub

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

This patch renames lib/domain.js to lib/url.js and the functions getDomain() and suffixes() to getBaseDomain() and domainSuffixes() respectively. The reason for this change is that I intend to add more URL-related functions in this file. Domains are ultimately parts of URLs; therefore we could have all of it in one lib/url.js file.

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rename testGetDomain #

Patch Set 4 : Add tests for domainSuffixes #

Created: Feb. 19, 2019, 2:36 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -37 lines)			Patch
M	lib/elemHide.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/filterClasses.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/matcher.js	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	lib/url.js	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	test/url.js	View	1 2 3	5 chunks	+74 lines, -24 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages