Issue 7303 - Deprecate the use of String.prototype.substr()

lib/content/elemHideEmulation.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 410 matching lines @@
 
   *findPropsSelectors(styles, prefix, regexp)
   {
     for (let style of styles)
       if (regexp.test(style.style))
         for (let subSelector of style.subSelectors)
         {
           if (subSelector.startsWith("*") &&
               !incompletePrefixRegexp.test(prefix))
           {
-            subSelector = subSelector.substr(1);
+            subSelector = subSelector.substring(1);
           }
           let idx = subSelector.lastIndexOf("::");
           if (idx != -1)
-            subSelector = subSelector.substr(0, idx);
+            subSelector = subSelector.substring(0, idx);
           yield qualifySelector(subSelector, prefix);
         }
   }
 
   *getSelectors(prefix, subtree, styles, targets)
   {
     for (let selector of this.findPropsSelectors(styles, prefix, this._regexp))
       yield [selector, subtree];
   }
 }
@@ skipping 191 matching lines @@
   {
     if (selector.length == 0)
       return [];
 
     let match = abpSelectorRegexp.exec(selector);
     if (!match)
       return [new PlainSelector(selector)];
 
     let selectors = [];
     if (match.index > 0)
-      selectors.push(new PlainSelector(selector.substr(0, match.index)));
+      selectors.push(new PlainSelector(selector.substring(0, match.index)));
 
     let startIndex = match.index + match[0].length;
     let content = parseSelectorContent(selector, startIndex);
     if (!content)
     {
       console.error(new SyntaxError("Failed to parse Adblock Plus " +
                                     `selector ${selector} ` +
                                     "due to unmatched parentheses."));
       return null;
     }
@@ skipping 10 matching lines @@
       selectors.push(new ContainsSelector(content.text));
     else
     {
       // this is an error, can't parse selector.
       console.error(new SyntaxError("Failed to parse Adblock Plus " +
                                     `selector ${selector}, invalid ` +
                                     `pseudo-class :-abp-${match[1]}().`));
       return null;
     }
 
-    let suffix = this.parseSelector(selector.substr(content.end + 1));
+    let suffix = this.parseSelector(selector.substring(content.end + 1));
     if (suffix == null)
       return null;
 
     selectors.push(...suffix);
 
     if (selectors.length == 1 && selectors[0] instanceof ContainsSelector)
     {
       console.error(new SyntaxError("Failed to parse Adblock Plus " +
                                     `selector ${selector}, can't ` +
                                     "have a lonely :-abp-contains()."));
@@ skipping 275 matching lines @@
           characterData: shouldObserveCharacterData(this.patterns),
           subtree: true
         }
       );
       this.document.addEventListener("load", this.onLoad.bind(this), true);
     }
   }
 }
 
 exports.ElemHideEmulation = ElemHideEmulation;