Issue 7303 - Deprecate the use of String.prototype.substr()

Issue 7303 - Deprecate the use of String.prototype.substr()

[Manish Jethani, 2019-02-21 14:46:34]

This needs a rebase.

[Manish Jethani, 2019-02-21 14:46:34]

This needs a rebase.

[hub, 2019-02-21 14:49:04]

rebased

[Manish Jethani, 2019-02-21 15:04:39]

There are two places where I think we should leave the call to substr() as it
is: domainSuffixes() and matchesLocation(). These are hot spots, and it seems
substr() has a _slight_ performance advantage over substring() at least on V8.

Otherwise looks good.

https://codereview.adblockplus.org/30011555/diff/30013594/lib/filterClasses.js
File lib/filterClasses.js (right):

https://codereview.adblockplus.org/30011555/diff/30013594/lib/filterClasses.j...
lib/filterClasses.js:915: pattern = pattern.substring(2);
This is a hot spot, let's leave it as it is.

https://codereview.adblockplus.org/30011555/diff/30013594/lib/url.js
File lib/url.js (right):

https://codereview.adblockplus.org/30011555/diff/30013594/lib/url.js#newcode74
lib/url.js:74: domain = dotIndex == -1 ? "" : domain.substring(dotIndex + 1);
This is a hot spot, let's leave it as it is.

[hub, 2019-02-21 18:09:42]

updated.

https://codereview.adblockplus.org/30011555/diff/30013594/lib/filterClasses.js
File lib/filterClasses.js (right):

https://codereview.adblockplus.org/30011555/diff/30013594/lib/filterClasses.j...
lib/filterClasses.js:915: pattern = pattern.substring(2);
On 2019/02/21 15:04:39, Manish Jethani wrote:
> This is a hot spot, let's leave it as it is.

Done.

https://codereview.adblockplus.org/30011555/diff/30013594/lib/url.js
File lib/url.js (right):

https://codereview.adblockplus.org/30011555/diff/30013594/lib/url.js#newcode74
lib/url.js:74: domain = dotIndex == -1 ? "" : domain.substring(dotIndex + 1);
On 2019/02/21 15:04:39, Manish Jethani wrote:
> This is a hot spot, let's leave it as it is.

Done.

[Manish Jethani, 2019-02-21 19:58:55]

LGTM

[Manish Jethani, 2019-02-21 19:59:20]

On 2019/02/21 19:58:55, Manish Jethani wrote:
> LGTM

Can we remove the unnecessary dot from the end of the summary?

[hub, 2019-02-21 20:10:26]

On 2019/02/21 19:59:20, Manish Jethani wrote:
> On 2019/02/21 19:58:55, Manish Jethani wrote:
> > LGTM
> 
> Can we remove the unnecessary dot from the end of the summary?

Will do. Thanks !