Issue 7303 - Deprecate the use of String.prototype.substr()

test/matcher.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 70 matching lines @@
       result = result.text;
 
     test.equal(result, expected, "combinedMatch(" + location + ", " + contentType + ", " + docDomain + ", " + (thirdParty ? "third-party" : "first-party") + ", " + (sitekey || "no-sitekey") + ", " + (specificOnly ? "specificOnly" : "not-specificOnly") + ") with:\n" + filters.join("\n"));
 
     // Generic whitelisting rules can match for specificOnly searches, so we
     // can't easily know which rule will match for these whitelisting tests
     if (specificOnly)
       continue;
 
     // For next run: add whitelisting filters for filters that aren't already
-    filters = filters.map(text => text.substr(0, 2) == "@@" ? text : "@@" + text);
-    if (expected && expected.substr(0, 2) != "@@")
+    filters = filters.map(text => text.substring(0, 2) == "@@" ? text : "@@" + text);
+    if (expected && expected.substring(0, 2) != "@@")
       expected = "@@" + expected;
   }
 }
 
 function checkSearch(test, filters, location, contentType, docDomain,
                      thirdParty, sitekey, specificOnly, filterType,
                      expected)
 {
   let matcher = new CombinedMatcher();
   for (let filter of filters)
@@ skipping 331 matching lines @@
   matcher.remove(Filter.fromText("/example/*$~third-party"));
 
   test.equal(matcher._blacklist._filterDomainMapsByKeyword.size, 0);
 
   test.ok(!matcher.matchesAny("https://example.com/example/image.jpg",
                               RegExpFilter.typeMap.IMAGE, "example.com",
                               false));
 
   test.done();
 };