Issue 7303 - Deprecate the use of String.prototype.substr()

lib/url.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 53 matching lines @@
  *
  * @yields {string} The next suffix for the domain.
  */
 function* domainSuffixes(domain, includeBlank = false)
 {
   while (domain != "")
   {
     yield domain;
 
     let dotIndex = domain.indexOf(".");
-    domain = dotIndex == -1 ? "" : domain.substr(dotIndex + 1);
+    domain = dotIndex == -1 ? "" : domain.substring(dotIndex + 1);

[Manish Jethani, 2019/02/21 15:04:39]

This is a hot spot, let's leave it as it is.

[hub, 2019/02/21 18:09:42]

Done.

   }
 
   if (includeBlank)
     yield "";
 }
 
 exports.domainSuffixes = domainSuffixes;
 
 /**
  * Checks whether the given hostname is a domain.
@@ skipping 68 matching lines @@
   if (requestHostname == documentHostname)
     return false;
 
   if (!isDomain(requestHostname) || !isDomain(documentHostname))
     return true;
 
   return getBaseDomain(requestHostname) != getBaseDomain(documentHostname);
 }
 
 exports.isThirdParty = isThirdParty;