Issue 7303 - Deprecate the use of String.prototype.substr()

lib/matcher.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 386 matching lines @@
       return result;
 
     let candidates = pattern.toLowerCase().match(allKeywordsRegExp);
     if (!candidates)
       return result;
 
     let resultCount = 0xFFFFFF;
     let resultLength = 0;
     for (let i = 0, l = candidates.length; i < l; i++)
     {
-      let candidate = candidates[i].substr(1);
+      let candidate = candidates[i].substring(1);
       let simpleFilters = this._simpleFiltersByKeyword.get(candidate);
       let complexFilters = this._complexFiltersByKeyword.get(candidate);
       let count = (typeof simpleFilters != "undefined" ?
                      simpleFilters.size : 0) +
                   (typeof complexFilters != "undefined" ?
                      complexFilters.size : 0);
       if (count < resultCount ||
           (count == resultCount && candidate.length > resultLength))
       {
         result = candidate;
@@ skipping 458 matching lines @@
 
 exports.CombinedMatcher = CombinedMatcher;
 
 /**
  * Shared {@link CombinedMatcher} instance that should usually be used.
  * @type {CombinedMatcher}
  */
 let defaultMatcher = new CombinedMatcher();
 
 exports.defaultMatcher = defaultMatcher;