Issue 7303 - Deprecate the use of String.prototype.substr()

test/_common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 218 matching lines @@
       if (method != "GET")
         throw new Error("Only GET requests are supported");
       if (typeof async != "undefined" && !async)
         throw new Error("Sync requests are not supported");
       if (typeof user != "undefined" || typeof password != "undefined")
         throw new Error("User authentification is not supported");
 
       let match = /^data:[^,]+,/.exec(url);
       if (match)
       {
-        this._data = decodeURIComponent(url.substr(match[0].length));
+        this._data = decodeURIComponent(url.substring(match[0].length));
         return;
       }
 
-      if (url.substr(0, this._host.length + 1) != this._host + "/")
+      if (url.substring(0, this._host.length + 1) != this._host + "/")
         throw new Error("Unexpected URL: " + url + " (URL starting with " + this._host + "expected)");
 
-      this._path = url.substr(this._host.length);
+      this._path = url.substring(this._host.length);
 
       let queryIndex = this._path.indexOf("?");
       this._queryString = "";
       if (queryIndex >= 0)
       {
-        this._queryString = this._path.substr(queryIndex + 1);
-        this._path = this._path.substr(0, queryIndex);
+        this._queryString = this._path.substring(queryIndex + 1);
+        this._path = this._path.substring(0, queryIndex);
       }
     },
 
     send(data)
     {
       if (!this._data && !this._path)
         throw new Error("No request path set");
       if (typeof data != "undefined" && data)
         throw new Error("Sending data to server is not supported");
 
@@ skipping 141 matching lines @@
       }
     })
   };
 };
 
 exports.unexpectedError = function(error)
 {
   console.error(error);
   this.ok(false, "Unexpected error: " + error);
 };