Issue 7303 - Deprecate the use of String.prototype.substr()

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 894 matching lines @@
 
     if (!this.matchCase)
       location = lowerCaseLocation || location.toLowerCase();
 
     let {pattern} = this;
 
     let startsWithDoubleAnchor = pattern[0] == "|" && pattern[1] == "|";
     let endsWithSeparator = pattern[pattern.length - 1] == "^";
 
     if (startsWithDoubleAnchor)
-      pattern = pattern.substring(2);

[Manish Jethani, 2019/02/21 15:04:39]

This is a hot spot, let's leave it as it is.

[hub, 2019/02/21 18:09:42]

Done.

+      pattern = pattern.substr(2);
 
     if (endsWithSeparator)
       pattern = pattern.slice(0, -1);
 
     let index = location.indexOf(pattern);
 
     // The "||" prefix requires that the text that follows does not start
     // with a forward slash.
     return index != -1 &&
            (!startsWithDoubleAnchor || location[index] != "/" &&
@@ skipping 511 matching lines @@
 
   /**
    * Script that should be executed
    * @type {string}
    */
   get script()
   {
     return this.body;
   }
 });