Issue 7029 - Remove subscriptions property of Filter object

lib/iniParser.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 89 matching lines @@
                 this.subscriptions.push(subscription);
               break;
 
             case "subscription filters":
               if (this.subscriptions.length)
               {
                 let currentSubscription = this.subscriptions[
                   this.subscriptions.length - 1
                 ];
                 for (let text of this._curObj)
-                {
                   currentSubscription.addFilterText(text);
-                  Filter.fromText(text).addSubscription(currentSubscription);

[Manish Jethani, 2019/03/30 21:01:44]

A side effect of this change is that `Filter` objects are not created for
disabled subscriptions. They get created for enabled subscriptions for the first
time in `lib/filterListener.js` instead.

Unfortunately this does not last for too long because within a minute of the
extension being loaded the lists are synced and in `onSubscriptionUpdated()` in
`lib/filterListener.js` we end up creating objects (even for filters we are
about to remove!). I intend to address all of this, step by step.

[hub, 2019/04/04 03:48:15]

In this patch or in a future one?

[Manish Jethani, 2019/04/04 05:44:20]

In a future one, because it is an enhancement on top of this and not necessary
to do for what we're trying to achieve here. The aim of this patch is to make
all filter objects lose any state so they can be discarded. After this, we can
do <https://codereview.adblockplus.org/29935564/> and then we should be able to
lose the `ElemHide` objects at least.

[hub, 2019/04/04 20:54:44]

Acknowledged.

-                }
               }
               break;
           }
         }
 
         if (line === null)
           return;
 
         this._curSection = match[1].toLowerCase();
         switch (this._curSection)
@@ skipping 19 matching lines @@
     }
     finally
     {
       Filter.knownFilters = origKnownFilters;
       Subscription.knownSubscriptions = origKnownSubscriptions;
     }
   }
 }
 
 exports.INIParser = INIParser;