Issue 30017558: Noissue - Use latest stable AMO api

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30017558: Noissue - Use latest stable AMO api (Closed)

Created:
Feb. 25, 2019, 9:03 a.m. by tlucas

Modified:
Feb. 25, 2019, 11:36 a.m.

Reviewers:
Vasily Kuznetsov

CC:
Sebastian Noack, kzar

Base URL:
https://hg.adblockplus.org/abpssembly/file/776cf4ca9d1d

Visibility:
Public.

Description

Noissue - Use latest stable AMO api

Patch Set 1 #

Patch Set 2 : #

Created: Feb. 25, 2019, 9:36 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	sitescripts/extensions/utils.py	View	1	1 chunk	+8 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

tlucas

Hey everyone. This fixes some the cronjob attempting to create update manifests for our extensions. ...

Feb. 25, 2019, 9:07 a.m. (2019-02-25 09:07:50 UTC) #1

Vasily Kuznetsov

On 2019/02/25 09:36:58, tlucas wrote: > Patch Set 2: > > Fix missing trailing comma ...

Feb. 25, 2019, 11:07 a.m. (2019-02-25 11:07:42 UTC) #3

tlucas

Feb. 25, 2019, 11:36 a.m. (2019-02-25 11:36:16 UTC) #4

On 2019/02/25 11:07:42, Vasily Kuznetsov wrote:
> On 2019/02/25 09:36:58, tlucas wrote:
> > Patch Set 2:
> > 
> > Fix missing trailing comma
> 
> Hi Tristan!
> 
> Some how I looked at the first patch initially and wrote a comment about the
> comma, only to see that it's fixed in the second patch. Good job reading my
mind
> from the past!
> 
> LGTM
> 
> Cheers,
> Vasily

Tox did the good job in this case ;)

Expand All Messages | Collapse All Messages