Issue 30020555: Issue 7317 - Make abp a namespace package

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30020555: Issue 7317 - Make abp a namespace package (Closed)

Created:
Feb. 28, 2019, 6:32 p.m. by Vasily Kuznetsov

Modified:
April 10, 2019, 3:28 p.m.

Reviewers:
Tudor Avram

Base URL:
https://hg.adblockplus.org/python-abp

Visibility:
Public.

Description

Issue 7317 - Make abp a namespace package Repository: https://hg.adblockplus.org/python-abp Base revision: - https://codereview.adblockplus.org/30021569 for patch set 2 - acc69bd3997e for patch set 1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Move py37 to a separate noissue #

Created: March 1, 2019, 3:11 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	abp/__init__.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	setup.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Vasily Kuznetsov

Hi Tudor, Remember some days ago you had problems with importing some subpackages of abp ...

Feb. 28, 2019, 6:35 p.m. (2019-02-28 18:35:22 UTC) #1

Tudor Avram

Hi Vasily, That's great! Thanks for that! I only have one small nit (see below), ...

March 1, 2019, 1:01 p.m. (2019-03-01 13:01:50 UTC) #2

Vasily Kuznetsov

March 1, 2019, 3:15 p.m. (2019-03-01 15:15:30 UTC) #3

On 2019/03/01 13:01:50, Tudor Avram wrote:
> Hi Vasily,
> 
> That's great! Thanks for that! I only have one small nit (see below), but
other
> than that LGTM.
> 
> Tudor.
> 
> P.S.: I guess we should do this in `abp-request-classifier`, too, right?
> 
> https://codereview.adblockplus.org/30020555/diff/30020556/setup.py
> File setup.py (right):
> 
> https://codereview.adblockplus.org/30020555/diff/30020556/setup.py#newcode50
> setup.py:50: 'Programming Language :: Python :: 3.7',
> Nit: Shouldn't we also add Python 3.7 to the `tox` environments?

Hi Tudor,

Thanks for catching that, I thought py37 was already in tox.ini. I have moved
those changes to a separate review: https://codereview.adblockplus.org/30021569/

Cheers,
Vasily

Expand All Messages | Collapse All Messages