Issue 30025555: Issue 6820 - Move tests to mocha

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 30025555: Issue 6820 - Move tests to mocha (Closed)

Created:
March 7, 2019, 1:14 p.m. by hub

Modified:
May 15, 2019, 10:28 p.m.

Reviewers:
hub

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Issue 6820 - Move tests to mocha

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased #

Created: April 10, 2019, 6:33 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5795 lines, -6018 lines)			Patch
M	package.json	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/.eslintrc.json	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/browser.js	View		3 chunks	+49 lines, -95 lines	0 comments	Download
M	test/browser/_bootstrap.js	View		1 chunk	+38 lines, -72 lines	0 comments	Download
M	test/browser/elemHideEmulation.js	View	1	1 chunk	+988 lines, -1022 lines	0 comments	Download
M	test/browser/snippets.js	View	1 2	1 chunk	+161 lines, -157 lines	0 comments	Download
M	test/caching.js	View		1 chunk	+78 lines, -74 lines	0 comments	Download
M	test/domainRestrictions.js	View	1	1 chunk	+170 lines, -175 lines	0 comments	Download
M	test/elemHide.js	View	1 2	1 chunk	+310 lines, -307 lines	0 comments	Download
M	test/filterClasses.js	View		2 chunks	+519 lines, -544 lines	0 comments	Download
M	test/filterListener.js	View	1 2	1 chunk	+272 lines, -280 lines	0 comments	Download
M	test/filterNotifier.js	View		1 chunk	+77 lines, -79 lines	0 comments	Download
M	test/filterStorage.js	View	1 2	1 chunk	+394 lines, -408 lines	0 comments	Download
M	test/filterStorage_readwrite.js	View	1 2	1 chunk	+212 lines, -213 lines	0 comments	Download
M	test/matcher.js	View	1	1 chunk	+359 lines, -369 lines	0 comments	Download
M	test/notification.js	View	1	1 chunk	+484 lines, -479 lines	0 comments	Download
M	test/regexpFilters_matching.js	View	1	1 chunk	+316 lines, -334 lines	0 comments	Download
M	test/signatures.js	View		1 chunk	+110 lines, -116 lines	0 comments	Download
M	test/snippets.js	View	1	2 chunks	+224 lines, -230 lines	0 comments	Download
M	test/subscriptionClasses.js	View	1 2	1 chunk	+162 lines, -166 lines	0 comments	Download
M	test/synchronizer.js	View	1	1 chunk	+461 lines, -449 lines	0 comments	Download
M	test/url.js	View	1	1 chunk	+406 lines, -445 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

hub

Not ready for review. Currently the non browser test all pass. The browser tests needs ...

March 7, 2019, 1:15 p.m. (2019-03-07 13:15:52 UTC) #2

hub

May 15, 2019, 10:28 p.m. (2019-05-15 22:28:18 UTC) #4

Message was sent while issue was closed.

Just to be clear, it is being taken care differently.

See https://gitlab.com/eyeo/adblockplus/adblockpluscore/issues/14 for starter

Expand All Messages | Collapse All Messages