Issue 7411 - Update adblockpluscore dependency to hg:54c57142b0f4

[Manish Jethani, 2019-03-27 07:11:54]

Patch Set 1

[kzar, 2019-03-27 12:39:43]

LGTM

By the way, I wonder why you used Rietveld for this review? I would understand
if it was to mark the review confidential (since the corresponding issue was for
some reason), but since you didn't I wonder why not use a GitLab merge request?

I ask since I think the plan is to stop using Rietveld at some point, if there's
some way that GitLab merge requets don't meet your needs now would be the time
to bring it up.

[Manish Jethani, 2019-03-27 14:06:05]

On 2019/03/27 12:39:43, kzar wrote:

> By the way, I wonder why you used Rietveld for this review? I would understand
> if it was to mark the review confidential (since the corresponding issue was
for
> some reason), but since you didn't I wonder why not use a GitLab merge
request?

The short answer is that I do find Rietveld to be more convenient.

> I ask since I think the plan is to stop using Rietveld at some point, if
there's
> some way that GitLab merge requets don't meet your needs now would be the time
> to bring it up.

Let's discuss the details on a different forum.

[kzar, 2019-03-27 14:39:21]

On 2019/03/27 14:06:05, Manish Jethani wrote:
> On 2019/03/27 12:39:43, kzar wrote:
> > I ask since I think the plan is to stop using Rietveld at some point, if
> there's
> > some way that GitLab merge requets don't meet your needs now would be the
time
> > to bring it up.
> 
> Let's discuss the details on a different forum.
> The short answer is that I do find Rietveld to be more convenient.

Fair enough, but my advice is to bring it up now while you still have a chance
to. It would suck if we moved to a tool you didn't want to use, without
realising it.