Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 30033567: Issue 7387 - Onboarding shown again after upgrade (Closed)

Created:
March 28, 2019, 2:52 p.m. by diegocarloslima
Modified:
April 10, 2019, 1:24 p.m.
Reviewers:
anton, jens
Visibility:
Public.

Description

Issue 7387 - Onboarding shown again after upgrade

Patch Set 1 #

Total comments: 3

Patch Set 2 : Adjusting comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M mobile/android/base/java/org/mozilla/gecko/BrowserApp.java View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
diegocarloslima
March 28, 2019, 2:54 p.m. (2019-03-28 14:54:12 UTC) #1
jens
https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java File mobile/android/base/java/org/mozilla/gecko/BrowserApp.java (left): https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#oldcode1117 mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:1117: Not important at all, but there is a little ...
March 28, 2019, 4:05 p.m. (2019-03-28 16:05:28 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java File mobile/android/base/java/org/mozilla/gecko/BrowserApp.java (left): https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#oldcode1117 mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:1117: On 2019/03/28 16:05:28, jens wrote: > Not important at ...
March 28, 2019, 8:02 p.m. (2019-03-28 20:02:14 UTC) #3
anton
https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java File mobile/android/base/java/org/mozilla/gecko/BrowserApp.java (right): https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#newcode1118 mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:1118: // Mozilla changed the preference name, thus the first ...
March 29, 2019, 4:32 a.m. (2019-03-29 04:32:13 UTC) #4
jens
On 2019/03/29 04:32:13, anton wrote: > https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java > File mobile/android/base/java/org/mozilla/gecko/BrowserApp.java (right): > > https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#newcode1118 > ...
April 5, 2019, 11:03 a.m. (2019-04-05 11:03:10 UTC) #5
anton
April 5, 2019, 11:06 a.m. (2019-04-05 11:06:47 UTC) #6 
On 2019/04/05 11:03:10, jens wrote:
> On 2019/03/29 04:32:13, anton wrote:
> >
>
https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base...
> > File mobile/android/base/java/org/mozilla/gecko/BrowserApp.java (right):
> > 
> >
>
https://codereview.adblockplus.org/30033567/diff/30033568/mobile/android/base...
> > mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:1118: // Mozilla
> > changed the preference name, thus the first run is being showed again after
> > updating. We don't wanna that
> > 'showed' -> 'shown' ?
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld